Re: [ovs-dev] [PATCH] dpif: Add much more documentation.

2013-01-09 Thread Ben Pfaff
Thanks, I applied it to master. On Wed, Jan 09, 2013 at 02:38:16PM -0800, Justin Pettit wrote: > Looks great. Thanks. > > --Justin > > > On Jan 9, 2013, at 2:10 PM, Ben Pfaff wrote: > > > On Tue, Jan 08, 2013 at 06:16:58PM -0800, Justin Pettit wrote: > >>> + *- A "flow", that is, a summa

Re: [ovs-dev] [PATCH] dpif: Add much more documentation.

2013-01-09 Thread Justin Pettit
Looks great. Thanks. --Justin On Jan 9, 2013, at 2:10 PM, Ben Pfaff wrote: > On Tue, Jan 08, 2013 at 06:16:58PM -0800, Justin Pettit wrote: >>> + *- A "flow", that is, a summary of the headers in a Ethernet packet. >>> The >> >> s/a/an/ > > Fixed. > >> This sort of sounds like only t

Re: [ovs-dev] [PATCH] dpif: Add much more documentation.

2013-01-09 Thread Ben Pfaff
On Tue, Jan 08, 2013 at 06:16:58PM -0800, Justin Pettit wrote: > > + *- A "flow", that is, a summary of the headers in a Ethernet packet. > > The > > s/a/an/ Fixed. > This sort of sounds like only the Ethernet header fields make up the > flow. Maybe "L2/L3/L4 headers" or something like th

Re: [ovs-dev] [PATCH] dpif: Add much more documentation.

2013-01-08 Thread Justin Pettit
This is great! Thanks for taking the time to write it up. I just have a few comments: > + *- A "flow", that is, a summary of the headers in a Ethernet packet. > The s/a/an/ This sort of sounds like only the Ethernet header fields make up the flow. Maybe "L2/L3/L4 headers" or something

[ovs-dev] [PATCH] dpif: Add much more documentation.

2012-12-07 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- PORTING | 11 +- lib/dpif-provider.h |4 +- lib/dpif.h | 302 ++- 3 files changed, 310 insertions(+), 7 deletions(-) diff --git a/PORTING b/PORTING index ffde296..91630b1 100644 --- a/PORTING