Re: [ovs-dev] [PATCH] docs: update CONTRIBUTING.md

2015-02-15 Thread Ben Pfaff
On Tue, Feb 10, 2015 at 02:46:22PM +, Mark Kavanagh wrote: > Patches that modify existing code can break expected behaviour. > Flag this by testing the patch with 'make check' prior to submission. > > Furthermore, it is not sufficient to only test patches that add files > using 'make distcheck

[ovs-dev] [PATCH] docs: update CONTRIBUTING.md

2015-02-11 Thread Mark Kavanagh
Patches that modify existing code can break expected behaviour. Flag this by testing the patch with 'make check' prior to submission. Furthermore, it is not sufficient to only test patches that add files using 'make distcheck';the compile flags for this target could change the definition of some f