Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-18 Thread Eitan Eliahu
will be handled by the system, Thanks! Eitan From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] Sent: Thursday, September 18, 2014 5:17 AM To: Eitan Eliahu; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-18 Thread Samuel Ghinet
From: Eitan Eliahu [elia...@vmware.com] Sent: Thursday, September 18, 2014 2:35 PM To: Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup No Sam, Duplication of handles is done

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-18 Thread Eitan Eliahu
4:27 AM To: Eitan Eliahu; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup Hi Eitan, By duplication of HANDLES, you mean assignment (like, "HANDLE a = CreateFile(params); HANDLE b = a;")? We do have ca

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-18 Thread Samuel Ghinet
e? Thanks, Sam, From: Eitan Eliahu [elia...@vmware.com] Sent: Thursday, September 18, 2014 2:16 PM To: Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup Hi Sam, A

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-18 Thread Eitan Eliahu
Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup Eitan, > In case that a handle is duplicated in user mode there will be multiple file > handles per file object associated with the handle returned by the system >

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-18 Thread Samuel Ghinet
ure this is a real case? Thanks, Sam From: Eitan Eliahu [elia...@vmware.com] Sent: Monday, September 15, 2014 6:50 PM To: Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanu

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-15 Thread Samuel Ghinet
nday, September 14, 2014 8:04 PM To: Eitan Eliahu; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup I have a question here, is a file HANDLE normally used by only one userspace thread at a time (so that if you have mu

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-15 Thread Eitan Eliahu
a lot (no lock should be used). Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju Sent: Monday, September 15, 2014 8:09 AM To: Samuel Ghinet Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during inst

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-15 Thread Eitan Eliahu
h.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup I have a question here, is a file HANDLE normally used by only one userspace thread at a time (so that if you have multiple threads, each thread will have its own unique file HANDLEs), or each threa

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-15 Thread Eitan Eliahu
lf Of Samuel Ghinet Sent: Sunday, September 14, 2014 7:38 PM To: Nithin Raju Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup I meant in the sense, if it is necessary. AFAIK, the IO pending can only happen in non-dump operations

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-15 Thread Nithin Raju
On Sep 14, 2014, at 8:03 PM, Samuel Ghinet mailto:sghi...@cloudbasesolutions.com>> wrote: I have a question here, is a file HANDLE normally used by only one userspace thread at a time (so that if you have multiple threads, each thread will have its own unique file HANDLEs), or each thread may

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-15 Thread Nithin Raju
On Sep 14, 2014, at 7:38 PM, Samuel Ghinet wrote: > I meant in the sense, if it is necessary. AFAIK, the IO pending can only > happen in non-dump operations (and here, non-dump netlink pids). > Therefore, I don't know if it is really useful to FreeDumpState in a pending > IO cancel callback f

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-14 Thread Samuel Ghinet
From: Eitan Eliahu [elia...@vmware.com] Sent: Saturday, September 13, 2014 12:01 AM To: Nithin Raju Cc: Samuel Ghinet; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup My understating is the Cleanup callback is called when the file

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-14 Thread Samuel Ghinet
te is empty, instead? Thanks, Sam From: Nithin Raju [nit...@vmware.com] Sent: Thursday, September 11, 2014 4:41 AM To: Samuel Ghinet Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup O

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-12 Thread Eitan Eliahu
: Nithin Raju Sent: Friday, September 12, 2014 1:02 PM To: Eitan Eliahu Cc: Samuel Ghinet; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup On Sep 12, 2014, at 12:46 PM, Eitan Eliahu mailto:elia...@vmware.com>> wrote: Sor

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-12 Thread Nithin Raju
On Sep 12, 2014, at 12:46 PM, Eitan Eliahu mailto:elia...@vmware.com>> wrote: Sorry for coming late on this one. We should free the dump state when the system calls the driver on cleanup as you did. But, the cleanup IOCTL can be (actually will be) executed from a different thread context. This

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-12 Thread Eitan Eliahu
-Original Message- From: Nithin Raju Sent: Thursday, September 11, 2014 11:09 PM To: Eitan Eliahu Cc: Samuel Ghinet; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup Samuel/Eitan, If you are OK with the changes, can you pls. give a Acked

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-11 Thread Nithin Raju
dev@openvswitch.org; Nithin Raju > Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during > instance cleanup > > Hey Nithin, > > AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a > callback called by NDIS when an IO is pending and the

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-11 Thread Eitan Eliahu
: Wednesday, September 10, 2014 4:15 PM To: dev@openvswitch.org; Nithin Raju Subject: Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup Hey Nithin, AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a callback called by NDIS when an IO is pending and the

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-10 Thread Nithin Raju
On Sep 10, 2014, at 4:15 PM, Samuel Ghinet wrote: > Hey Nithin, > > AFAIK OvsCleanupOpenInstance is called by OvsCleanupDevice, which is a > callback called by NDIS when an IO is pending and the file must be closed. > FreeUserDumpState is only for dump operations. > > Is it possible that an I

Re: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-10 Thread Samuel Ghinet
operation to be in progress, for the same file? Sam Date: Wed, 10 Sep 2014 13:17:17 -0700 From: Nithin Raju To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup Message-ID: <1410380237-28

[ovs-dev] [PATCH] datapath-windows: cleanup dump state during instance cleanup

2014-09-10 Thread Nithin Raju
Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Datapath.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index c145d00..d1f4b9d 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b/datapath