Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Sorin Vinturis
: Solved BSOD when adding OVS ports > On Aug 4, 2015, at 1:45 AM, Sorin Vinturis > wrote: > > Nithin, that check (if (nbl->SourceHandle == context->ovsPool.ndisHandle) ..) > at L564 was added by my patch. Please see here: > https://urldefense.proof

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Nithin Raju
> On Aug 4, 2015, at 1:45 AM, Sorin Vinturis > wrote: > > Nithin, that check (if (nbl->SourceHandle == context->ovsPool.ndisHandle) ..) > at L564 was added by my patch. Please see here: > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_commit_d50b88bf830c401636

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Sorin Vinturis
re.com] Sent: Monday, 3 August, 2015 15:45 To: Sorin Vinturis Cc: Eitan Eliahu; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports > On Aug 2, 2015, at 9:33 PM, Sorin Vinturis > wrote: > > Hi Nithin, > > Yes, the second chec

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-03 Thread Nithin Raju
> On Aug 2, 2015, at 9:33 PM, Sorin Vinturis > wrote: > > Hi Nithin, > > Yes, the second check, from the 564 line, is caught by the case when the > OvsInitExternalNBLContext() function is called with the NBL created by > OvsPartialCopyNBL(). Right, so, do we still need your patch since L564

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-02 Thread Sorin Vinturis
To: Eitan Eliahu Cc: Sorin Vinturis; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports hi Sorin, In OvsInitExternalNBLContext(), there’s the following check: 563 if (poolHandle == context->ovsPool.ndisHandle ||

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-31 Thread Nithin Raju
:02 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports > > This BSOD occurred in the context of a packet (NBL) with multiple > NET_BUFFER(s) (NBs). The reason for the BSOD is due to the marking of NBLs > created by OVS as bein

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-30 Thread Sorin Vinturis
Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports hi Sorin, OvsInitExternalNBLContext() is called from OvsStartNBLIngress() which is the function that hooks into NDIS to get hold of packets in the ingress path. Typically these are

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-30 Thread Nithin Raju
hi Sorin, OvsInitExternalNBLContext() is called from OvsStartNBLIngress() which is the function that hooks into NDIS to get hold of packets in the ingress path. Typically these are packets that are generated by VMs, or it could be generated by an layered driver above OVS. Under what conditions

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-01 Thread Eitan Eliahu
-Original Message- From: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Wednesday, 1 July, 2015 18:12 To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports Hi Sorin, Thank you for debugging this issue. I think that the NBL

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-01 Thread Sorin Vinturis
: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Wednesday, 1 July, 2015 18:12 To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports Hi Sorin, Thank you for debugging this issue. I think that the NBL context signature is used for

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-01 Thread Eitan Eliahu
(e.g. a status/flag)? Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Wednesday, July 01, 2015 7:02 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports This BSOD occurred

[ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-01 Thread Sorin Vinturis
This BSOD occurred in the context of a packet (NBL) with multiple NET_BUFFER(s) (NBs). The reason for the BSOD is due to the marking of NBLs created by OVS as being external and wrongly completing them. This patch should be applied both on master and branch 2.4. Signed-off-by: Sorin Vinturis Rep