Re: [ovs-dev] [PATCH] datapath: refactor ovs flow extract API.

2014-08-05 Thread Pravin Shelar
On Tue, Aug 5, 2014 at 12:32 PM, Andy Zhou wrote: > The refactor is pretty nice in general. I wonder if the new public > ovs_flow_extrac_ APIs can actually reflect the intended use case as > highlighted in the commit message. > ok. > Also, It may be nice to separate out the ovs_flow_extract__ use

Re: [ovs-dev] [PATCH] datapath: refactor ovs flow extract API.

2014-08-05 Thread Andy Zhou
The refactor is pretty nice in general. I wonder if the new public ovs_flow_extrac_ APIs can actually reflect the intended use case as highlighted in the commit message. Also, It may be nice to separate out the ovs_flow_extract__ use cases for recirc. Andy On Tue, Jul 29, 2014 at 3:25 PM, Pravi

[ovs-dev] [PATCH] datapath: refactor ovs flow extract API.

2014-07-29 Thread Pravin B Shelar
OVS flow extract is called on packet receive or packet execute code path. Following patch defines separate API for these two cases to simplify code. Signed-off-by: Pravin B Shelar --- datapath/actions.c | 3 +- datapath/datapath.c | 8 ++--- datapath/flow.c | 82 +