Re: [ovs-dev] [PATCH] datapath: handle recirculation loop detection

2014-05-02 Thread Andy Zhou
On Fri, May 2, 2014 at 6:22 AM, Thomas F Herbert wrote: > On 5/1/2014 4:21 PM, Jesse Gross wrote: >> >> On Wed, Apr 30, 2014 at 4:46 PM, Andy Zhou wrote: >>> >>> diff --git a/datapath/actions.c b/datapath/actions.c >>> index 5871d82..5556a0c 100644 >>> --- a/datapath/actions.c >>> +++ b/datapath/

Re: [ovs-dev] [PATCH] datapath: handle recirculation loop detection

2014-05-02 Thread Thomas F Herbert
On 5/1/2014 4:21 PM, Jesse Gross wrote: On Wed, Apr 30, 2014 at 4:46 PM, Andy Zhou wrote: diff --git a/datapath/actions.c b/datapath/actions.c index 5871d82..5556a0c 100644 --- a/datapath/actions.c +++ b/datapath/actions.c @@ -644,22 +649,24 @@ static DEFINE_PER_CPU(struct loop_counter, loop_co

Re: [ovs-dev] [PATCH] datapath: handle recirculation loop detection

2014-05-01 Thread Andy Zhou
Thanks Jesse for the review. Push to master and branch-2.2 with the fix and some other clean ups. On Thu, May 1, 2014 at 1:21 PM, Jesse Gross wrote: > On Wed, Apr 30, 2014 at 4:46 PM, Andy Zhou wrote: >> diff --git a/datapath/actions.c b/datapath/actions.c >> index 5871d82..5556a0c 100644 >> ---

Re: [ovs-dev] [PATCH] datapath: handle recirculation loop detection

2014-05-01 Thread Jesse Gross
On Wed, Apr 30, 2014 at 4:46 PM, Andy Zhou wrote: > diff --git a/datapath/actions.c b/datapath/actions.c > index 5871d82..5556a0c 100644 > --- a/datapath/actions.c > +++ b/datapath/actions.c > @@ -644,22 +649,24 @@ static DEFINE_PER_CPU(struct loop_counter, > loop_counters); > static int loop_su

[ovs-dev] [PATCH] datapath: handle recirculation loop detection

2014-04-30 Thread Andy Zhou
Current datapath allows the same packet to be executed up to 5 times to avoid blowing out the kernel stack. Recirculation is currently also counted as one execution, but does not use same amount of stack compare to other services, such as IPsec. This patch introduces the concept of stack cost. Rec