Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-29 Thread Ansis Atteka
On Mon, Jul 28, 2014 at 7:54 PM, Jesse Gross wrote: > On Tue, Jul 22, 2014 at 9:34 AM, Jesse Gross wrote: >> On Mon, Jul 21, 2014 at 5:11 PM, Ansis Atteka wrote: >>> On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote: One thing that I worry about is that this has the possibility to ch

Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-28 Thread Jesse Gross
On Tue, Jul 22, 2014 at 9:34 AM, Jesse Gross wrote: > On Mon, Jul 21, 2014 at 5:11 PM, Ansis Atteka wrote: >> On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote: >>> One thing that I worry about is that this has the possibility to >>> change how the flow is reported - before the flow deletion it

Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-22 Thread Jesse Gross
On Mon, Jul 21, 2014 at 5:11 PM, Ansis Atteka wrote: > On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote: >> One thing that I worry about is that this has the possibility to >> change how the flow is reported - before the flow deletion it has >> Geneve options but immediately after the flow stil

Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-21 Thread Ansis Atteka
On Thu, Jul 17, 2014 at 4:08 PM, Jesse Gross wrote: > On Thu, Jul 17, 2014 at 3:46 PM, Ansis Atteka wrote: >> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c >> index 5f975a1..a4108c0 100644 >> --- a/datapath/flow_netlink.c >> +++ b/datapath/flow_netlink.c >> @@ -1034,7 +1034,7 @@

Re: [ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-17 Thread Jesse Gross
On Thu, Jul 17, 2014 at 3:46 PM, Ansis Atteka wrote: > diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c > index 5f975a1..a4108c0 100644 > --- a/datapath/flow_netlink.c > +++ b/datapath/flow_netlink.c > @@ -1034,7 +1034,7 @@ int ovs_nla_put_flow(struct datapath *dp, const struct > sw

[ovs-dev] [PATCH] datapath: do not add Geneve attributes if vport does not exist

2014-07-17 Thread Ansis Atteka
This patch fixes following kernel crash that could happen, if geneve vport was not added yet, but revalidator thread attempted to dump flows. To reproduce: 1. switch tunnel type between geneve and gre; and 2. run ping. BUG: unable to handle kernel NULL pointer dereference at 0048 IP: [