Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-04-02 Thread Jesse Gross
On Tue, Mar 31, 2015 at 4:34 PM, Pravin Shelar wrote: > On Tue, Mar 31, 2015 at 1:18 PM, Jesse Gross wrote: >> On Tue, Mar 31, 2015 at 1:12 PM, Pravin Shelar wrote: >>> On Tue, Mar 31, 2015 at 11:44 AM, Jesse Gross wrote: On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar wrote: > On Tue

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Pravin Shelar
On Tue, Mar 31, 2015 at 1:18 PM, Jesse Gross wrote: > On Tue, Mar 31, 2015 at 1:12 PM, Pravin Shelar wrote: >> On Tue, Mar 31, 2015 at 11:44 AM, Jesse Gross wrote: >>> On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar wrote: On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross wrote: > skb prot

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Jesse Gross
On Tue, Mar 31, 2015 at 1:12 PM, Pravin Shelar wrote: > On Tue, Mar 31, 2015 at 11:44 AM, Jesse Gross wrote: >> On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar wrote: >>> On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross wrote: skb protocol offsets are relative to the beginning of the buff

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Pravin Shelar
On Tue, Mar 31, 2015 at 11:44 AM, Jesse Gross wrote: > On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar wrote: >> On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross wrote: >>> skb protocol offsets are relative to the beginning of the >>> buffer and therefore must be updated if the buffer size is >>> ex

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Jesse Gross
On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar wrote: > On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross wrote: >> skb protocol offsets are relative to the beginning of the >> buffer and therefore must be updated if the buffer size is >> expanded. Kernel functions do this automatically for existing

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Pravin Shelar
On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross wrote: > skb protocol offsets are relative to the beginning of the > buffer and therefore must be updated if the buffer size is > expanded. Kernel functions do this automatically for existing > fields but obviously not for anything that we backport. Thi

[ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Jesse Gross
skb protocol offsets are relative to the beginning of the buffer and therefore must be updated if the buffer size is expanded. Kernel functions do this automatically for existing fields but obviously not for anything that we backport. This introduces a wrapper for pskb_expand_head() to update the i