Re: [ovs-dev] [PATCH] datapath: Remove redundant key ref from upcall_info.

2014-07-30 Thread Pravin Shelar
On Wed, Jul 30, 2014 at 12:25 PM, Andy Zhou wrote: > LGTM. A minor comment inline. It not essential, so please feel free to > ignore. > > Acked-by: Andy Zhou > > > >> @@ -353,25 +353,25 @@ static int queue_gso_packets(struct datapath *dp, >> struct sk_buff *skb, >> if (IS_ERR(segs)) >>

Re: [ovs-dev] [PATCH] datapath: Remove redundant key ref from upcall_info.

2014-07-30 Thread Andy Zhou
LGTM. A minor comment inline. It not essential, so please feel free to ignore. Acked-by: Andy Zhou > @@ -353,25 +353,25 @@ static int queue_gso_packets(struct datapath *dp, > struct sk_buff *skb, > if (IS_ERR(segs)) > return PTR_ERR(segs); > > + if (gso_type & S

[ovs-dev] [PATCH] datapath: Remove redundant key ref from upcall_info.

2014-07-29 Thread Pravin B Shelar
struct dp_upcall_info has pointer to pkt_key which is already available in OVS_CB. This also simplifies upcall handling for gso packet. Signed-off-by: Pravin B Shelar --- datapath/actions.c | 3 --- datapath/datapath.c | 34 +- datapath/datapath.h | 4 +--- 3