Re: [ovs-dev] [PATCH] datapath: Rehash 16-bit skbuff hashes into 32 bits.

2014-06-25 Thread Jesse Gross
On Wed, Jun 25, 2014 at 1:30 AM, Thomas Graf wrote: > On 06/24/14 at 06:46pm, Jesse Gross wrote: >> Currently, if the network stack provides skb->rxhash then we use it, >> otherwise we compute our own. However, on at least some versions of >> RHEL/CentOS, the stack provides a hash but it is 16 bit

Re: [ovs-dev] [PATCH] datapath: Rehash 16-bit skbuff hashes into 32 bits.

2014-06-25 Thread Thomas Graf
On 06/24/14 at 06:46pm, Jesse Gross wrote: > Currently, if the network stack provides skb->rxhash then we use it, > otherwise we compute our own. However, on at least some versions of > RHEL/CentOS, the stack provides a hash but it is 16 bits rather than > 32 bits. In cases where we use the upper m

[ovs-dev] [PATCH] datapath: Rehash 16-bit skbuff hashes into 32 bits.

2014-06-24 Thread Jesse Gross
Currently, if the network stack provides skb->rxhash then we use it, otherwise we compute our own. However, on at least some versions of RHEL/CentOS, the stack provides a hash but it is 16 bits rather than 32 bits. In cases where we use the upper most bits of the hash this is particularly bad becau