Re: [ovs-dev] [PATCH] datapath: Refactor get_dp() function, add get_dp_rcu()

2014-07-16 Thread Andy Zhou
Thanks for the review. Both points are valid. I have just posted another version of the re-factoring that should address the issues. On Wed, Jul 16, 2014 at 9:30 PM, Pravin Shelar wrote: > On Tue, Jul 15, 2014 at 2:56 PM, Andy Zhou wrote: >> The added get_dp_rcu() requires its caller to hold rc

Re: [ovs-dev] [PATCH] datapath: Refactor get_dp() function, add get_dp_rcu()

2014-07-16 Thread Pravin Shelar
On Tue, Jul 15, 2014 at 2:56 PM, Andy Zhou wrote: > The added get_dp_rcu() requires its caller to hold rcu lock. > get_dp() now requires caller to hold ovs lock. > > Sepearate APIs makes it clear on the intended use and the requirements > of its caller. > > Signed-off-by: Andy Zhou > --- > datap

[ovs-dev] [PATCH] datapath: Refactor get_dp() function, add get_dp_rcu()

2014-07-15 Thread Andy Zhou
The added get_dp_rcu() requires its caller to hold rcu lock. get_dp() now requires caller to hold ovs lock. Sepearate APIs makes it clear on the intended use and the requirements of its caller. Signed-off-by: Andy Zhou --- datapath/datapath.c | 23 +-- 1 file changed, 17 ins