Re: [ovs-dev] [PATCH] datapath: Per cpu flow stats.

2013-10-18 Thread Pravin Shelar
On Fri, Oct 18, 2013 at 8:25 AM, Andy Zhou wrote: > Do we still need a spinlock when we have per-cpu counters? > Yes, cmd OVS_FLOW_ATTR_CLEAR needs clear stats. So lock is required for atomic reset. > > On Fri, Oct 18, 2013 at 8:11 AM, Pravin B Shelar wrote: >> >> With mega flow implementation

Re: [ovs-dev] [PATCH] datapath: Per cpu flow stats.

2013-10-18 Thread Andy Zhou
Do we still need a spinlock when we have per-cpu counters? On Fri, Oct 18, 2013 at 8:11 AM, Pravin B Shelar wrote: > With mega flow implementation ovs flow can be shared between > multiple CPUs which makes stats updates highly contended > operation. Following patch allocates separate stats for

[ovs-dev] [PATCH] datapath: Per cpu flow stats.

2013-10-18 Thread Pravin B Shelar
With mega flow implementation ovs flow can be shared between multiple CPUs which makes stats updates highly contended operation. Following patch allocates separate stats for each CPU to make stats update scalable. Signed-off-by: Pravin B Shelar --- datapath/datapath.c | 54 ++