Re: [ovs-dev] [PATCH] datapath: Optimize recirc action.

2014-08-07 Thread Pravin Shelar
On Thu, Aug 7, 2014 at 2:01 PM, Andy Zhou wrote: > On Thu, Aug 7, 2014 at 12:32 PM, Pravin B Shelar wrote: >> OVS need to flow key for flow lookup in recic action. OVS >> does key extract in recic action. Most of cases we could >> use OVS_CB packet key directly and can avoid packet flow key >> ex

Re: [ovs-dev] [PATCH] datapath: Optimize recirc action.

2014-08-07 Thread Pravin Shelar
On Thu, Aug 7, 2014 at 1:27 PM, Jarno Rajahalme wrote: > Most of the time we do not need the updated key (i.e., when there is no > recirc action). Do you think it would be worthwhile to only update the key > when needed, e.g. by adding a “bool update_key;” member to struct > sw_flow_actions? >

Re: [ovs-dev] [PATCH] datapath: Optimize recirc action.

2014-08-07 Thread Andy Zhou
On Thu, Aug 7, 2014 at 12:32 PM, Pravin B Shelar wrote: > OVS need to flow key for flow lookup in recic action. OVS > does key extract in recic action. Most of cases we could > use OVS_CB packet key directly and can avoid packet flow key > extract. SET action we can update flow-key along with pack

Re: [ovs-dev] [PATCH] datapath: Optimize recirc action.

2014-08-07 Thread Jarno Rajahalme
Most of the time we do not need the updated key (i.e., when there is no recirc action). Do you think it would be worthwhile to only update the key when needed, e.g. by adding a “bool update_key;” member to struct sw_flow_actions? More comments below, Jarno On Aug 7, 2014, at 12:32 PM, Pravin

[ovs-dev] [PATCH] datapath: Optimize recirc action.

2014-08-07 Thread Pravin B Shelar
OVS need to flow key for flow lookup in recic action. OVS does key extract in recic action. Most of cases we could use OVS_CB packet key directly and can avoid packet flow key extract. SET action we can update flow-key along with packet to keep it consistent. But there are some action like MPLS pop