Re: [ovs-dev] [PATCH] datapath: Immediately exit on error in ovs_vport_cmd_set().

2013-05-02 Thread Jesse Gross
On Thu, May 2, 2013 at 10:38 AM, Pravin Shelar wrote: > On Thu, May 2, 2013 at 10:20 AM, Jesse Gross wrote: >> It is an error to try to change the type of a vport using the set >> command. However, while we check that this is an error, we still >> proceed to allocate memory which then gets freed

Re: [ovs-dev] [PATCH] datapath: Immediately exit on error in ovs_vport_cmd_set().

2013-05-02 Thread Pravin Shelar
On Thu, May 2, 2013 at 10:20 AM, Jesse Gross wrote: > It is an error to try to change the type of a vport using the set > command. However, while we check that this is an error, we still > proceed to allocate memory which then gets freed immediately. > This stops processing after noticing the erro

[ovs-dev] [PATCH] datapath: Immediately exit on error in ovs_vport_cmd_set().

2013-05-02 Thread Jesse Gross
It is an error to try to change the type of a vport using the set command. However, while we check that this is an error, we still proceed to allocate memory which then gets freed immediately. This stops processing after noticing the error, which does not actually fix a bug but is more correct. Si