Re: [ovs-dev] [PATCH] datapath: Fix typo in flow validation logic.

2013-08-09 Thread Jesse Gross
On Fri, Aug 9, 2013 at 3:50 PM, Kyle Mestery (kmestery) wrote: > On Aug 9, 2013, at 5:30 PM, Jesse Gross wrote: >> A bit shift operation is using the value '11' instead of '1' as the >> starting value. This only makes validation weaker than it should be >> so unless userspace is trying to install

Re: [ovs-dev] [PATCH] datapath: Fix typo in flow validation logic.

2013-08-09 Thread Kyle Mestery (kmestery)
On Aug 9, 2013, at 5:30 PM, Jesse Gross wrote: > A bit shift operation is using the value '11' instead of '1' as the > starting value. This only makes validation weaker than it should be > so unless userspace is trying to install an invalid flow there will > be no effect. > > Signed-off-by: Jesse

[ovs-dev] [PATCH] datapath: Fix typo in flow validation logic.

2013-08-09 Thread Jesse Gross
A bit shift operation is using the value '11' instead of '1' as the starting value. This only makes validation weaker than it should be so unless userspace is trying to install an invalid flow there will be no effect. Signed-off-by: Jesse Gross --- datapath/flow.c | 2 +- 1 file changed, 1 inser

Re: [ovs-dev] [PATCH] datapath: Fix typo

2012-08-31 Thread Jesse Gross
On Thu, Aug 30, 2012 at 8:35 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > datapath/actions.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.or

[ovs-dev] [PATCH] datapath: Fix typo

2012-08-30 Thread Joe Stringer
Signed-off-by: Joe Stringer --- datapath/actions.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/datapath/actions.c b/datapath/actions.c index 208f260..ec9b595 100644 --- a/datapath/actions.c +++ b/datapath/actions.c @@ -47,7 +47,7 @@ static int make_writable(struct sk

Re: [ovs-dev] [PATCH] datapath: fix typo in README

2012-07-16 Thread Jesse Gross
On Mon, Jul 16, 2012 at 5:36 PM, Leo Alterman wrote: > > Signed-off-by: Leo Alterman Since this is your first patch you can add yourself to the AUTHORS file but otherwise looks good to me. Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.or

[ovs-dev] [PATCH] datapath: fix typo in README

2012-07-16 Thread Leo Alterman
Signed-off-by: Leo Alterman --- datapath/README |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/README b/datapath/README index b8a048b..8fa2dd1 100644 --- a/datapath/README +++ b/datapath/README @@ -118,7 +118,7 @@ essentially like this, ignoring metadata: Naivel