Re: [ovs-dev] [PATCH] datapath: Fix tunnel source port selection for mega flow

2013-07-03 Thread Andy Zhou
Good point. I agree. This patch is only to fix a bug at hand. My understanding is that we will change to use skb_get_rxhash() after Pravin's tunnel patches are upstreamed. On Wed, Jul 3, 2013 at 4:34 AM, Rajahalme, Jarno (NSN - FI/Espoo) < jarno.rajaha...@nsn.com> wrote: > > On Jul 3, 2013, at

Re: [ovs-dev] [PATCH] datapath: Fix tunnel source port selection for mega flow

2013-07-03 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Jul 3, 2013, at 1:58 , ext Andy Zhou wrote: > diff --git a/datapath/tunnel.c b/datapath/tunnel.c > index 9102786..18c3622 100644 > --- a/datapath/tunnel.c > +++ b/datapath/tunnel.c > @@ -186,7 +186,9 @@ u16 ovs_tnl_get_src_port(struct sk_buff *skb) > int low; > int high; > uns

Re: [ovs-dev] [PATCH] datapath: Fix tunnel source port selection for mega flow

2013-07-02 Thread Andy Zhou
Thanks. On Tue, Jul 2, 2013 at 5:08 PM, Jesse Gross wrote: > No, I can fix it. I just wanted to make sure. > > On Tue, Jul 2, 2013 at 4:31 PM, Andy Zhou wrote: > > Sorry, I misread the jhash2 prototype. Do you need v2 patch? > > > > > > On Tue, Jul 2, 2013 at 4:05 PM, Jesse Gross wrote: > >>

Re: [ovs-dev] [PATCH] datapath: Fix tunnel source port selection for mega flow

2013-07-02 Thread Jesse Gross
No, I can fix it. I just wanted to make sure. On Tue, Jul 2, 2013 at 4:31 PM, Andy Zhou wrote: > Sorry, I misread the jhash2 prototype. Do you need v2 patch? > > > On Tue, Jul 2, 2013 at 4:05 PM, Jesse Gross wrote: >> >> On Tue, Jul 2, 2013 at 3:58 PM, Andy Zhou wrote: >> > diff --git a/datapat

Re: [ovs-dev] [PATCH] datapath: Fix tunnel source port selection for mega flow

2013-07-02 Thread Andy Zhou
Sorry, I misread the jhash2 prototype. Do you need v2 patch? On Tue, Jul 2, 2013 at 4:05 PM, Jesse Gross wrote: > On Tue, Jul 2, 2013 at 3:58 PM, Andy Zhou wrote: > > diff --git a/datapath/tunnel.c b/datapath/tunnel.c > > index 9102786..18c3622 100644 > > --- a/datapath/tunnel.c > > +++ b/data

Re: [ovs-dev] [PATCH] datapath: Fix tunnel source port selection for mega flow

2013-07-02 Thread Jesse Gross
On Tue, Jul 2, 2013 at 3:58 PM, Andy Zhou wrote: > diff --git a/datapath/tunnel.c b/datapath/tunnel.c > index 9102786..18c3622 100644 > --- a/datapath/tunnel.c > +++ b/datapath/tunnel.c > @@ -186,7 +186,9 @@ u16 ovs_tnl_get_src_port(struct sk_buff *skb) > int low; > int high; >

[ovs-dev] [PATCH] datapath: Fix tunnel source port selection for mega flow

2013-07-02 Thread Andy Zhou
Tunnel source port selection was based on hash value cached in the flow. This no longer works with mega flow, since all flows matching a mega flow will be transmitted with the same tunnel source port. This patch computes the tunnel source port at run time based on each incoming packet. Packets bel