Re: [ovs-dev] [PATCH] datapath: Fix tracking of flags seen in TCP flows.

2014-04-08 Thread Ben Pfaff
On Tue, Apr 08, 2014 at 02:33:55PM -0700, Jesse Gross wrote: > On Mon, Apr 7, 2014 at 3:35 PM, Ben Pfaff wrote: > > Flow statistics need to take into account the TCP flags from the packet > > currently being processed (in 'key'), not the TCP flags matched by the > > flow found in the kernel flow t

Re: [ovs-dev] [PATCH] datapath: Fix tracking of flags seen in TCP flows.

2014-04-08 Thread Jesse Gross
On Mon, Apr 7, 2014 at 3:35 PM, Ben Pfaff wrote: > Flow statistics need to take into account the TCP flags from the packet > currently being processed (in 'key'), not the TCP flags matched by the > flow found in the kernel flow table (in 'flow'). > > This bug made the Open vSwitch userspace fin_ti

Re: [ovs-dev] [PATCH] datapath: Fix tracking of flags seen in TCP flows.

2014-04-08 Thread Ben Pfaff
Jesse, I believe that Pravin is traveling today. Will you review this? On Mon, Apr 07, 2014 at 03:35:26PM -0700, Ben Pfaff wrote: > Flow statistics need to take into account the TCP flags from the packet > currently being processed (in 'key'), not the TCP flags matched by the > flow found in the

Re: [ovs-dev] [PATCH] datapath: Fix tracking of flags seen in TCP flows.

2014-04-08 Thread Jarno Rajahalme
Thanks for fixing this, Jarno Acked-by: Jarno Rajahalme On Apr 7, 2014, at 3:35 PM, Ben Pfaff wrote: > Flow statistics need to take into account the TCP flags from the packet > currently being processed (in 'key'), not the TCP flags matched by the > flow found in the kernel flow table (in '

[ovs-dev] [PATCH] datapath: Fix tracking of flags seen in TCP flows.

2014-04-07 Thread Ben Pfaff
Flow statistics need to take into account the TCP flags from the packet currently being processed (in 'key'), not the TCP flags matched by the flow found in the kernel flow table (in 'flow'). This bug made the Open vSwitch userspace fin_timeout action have no effect in many cases. Bug #1219516. R