On Fri, May 15, 2015 at 5:48 PM, Jesse Gross wrote:
> On Fri, May 15, 2015 at 5:05 PM, Pravin B Shelar wrote:
>> CHECK /home/pravin/ovs/w8/datapath/linux/flow_table.c
>> /home/pravin/ovs/w8/datapath/linux/flow_table.c:536:6: warning: symbol
>> 'ovs_flow_cmp_unmasked_key' was not declared. Shoul
On Fri, May 15, 2015 at 5:05 PM, Pravin B Shelar wrote:
> CHECK /home/pravin/ovs/w8/datapath/linux/flow_table.c
> /home/pravin/ovs/w8/datapath/linux/flow_table.c:536:6: warning: symbol
> 'ovs_flow_cmp_unmasked_key' was not declared. Should it be static?
>
> Signed-off-by: Pravin B Shelar
Acked
CHECK /home/pravin/ovs/w8/datapath/linux/flow_table.c
/home/pravin/ovs/w8/datapath/linux/flow_table.c:536:6: warning: symbol
'ovs_flow_cmp_unmasked_key' was not declared. Should it be static?
Signed-off-by: Pravin B Shelar
---
datapath/flow_table.c |4 ++--
1 files changed, 2 insertions(+)
Thanks, pushed with suggested changes.
On Wed, Jun 25, 2014 at 1:21 PM, Pravin Shelar wrote:
> On Mon, Jun 23, 2014 at 11:10 PM, Andy Zhou wrote:
>> Sparse gives "incompatible types in comparison expression (different
>> address spaces)" warning messages. Fix this by add rcu_dereference()
>> wra
On Mon, Jun 23, 2014 at 11:10 PM, Andy Zhou wrote:
> Sparse gives "incompatible types in comparison expression (different
> address spaces)" warning messages. Fix this by add rcu_dereference()
> wrappers.
>
> Reported-by: Ben Pfaff
> Signed-off-by: Andy Zhou
> ---
> datapath/flow_table.c | 6 ++
Sparse gives "incompatible types in comparison expression (different
address spaces)" warning messages. Fix this by add rcu_dereference()
wrappers.
Reported-by: Ben Pfaff
Signed-off-by: Andy Zhou
---
datapath/flow_table.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a
On Sun, Dec 22, 2013 at 3:36 PM, Chris Luke wrote:
> Pravin Shelar wrote (on Sun 22 Dec, 2013 at 20:12 GMT):
>>
>> On Sun, Dec 22, 2013 at 9:21 AM, Chris Luke wrote:
>>>
>>> Just a note; this adds datapath/linux/compat/include/linux/bug.h but
>>> doesn?t
>>>
>>> add that filename to datapath/linu
Pravin Shelar wrote (on Sun 22 Dec, 2013 at 20:12 GMT):
On Sun, Dec 22, 2013 at 9:21 AM, Chris Luke wrote:
Just a note; this adds datapath/linux/compat/include/linux/bug.h but doesn?t
add that filename to datapath/linux/Modules.mk, breaking the build with this
error:
The distribution is missin
ompiler.h \
> linux/compat/include/linux/compiler-gcc.h \
> linux/compat/include/linux/cpumask.h \
>
> From: dev-boun...@openvswitch.org [mailto:dev-boun...@openvswitch.org] On
> Behalf Of Andy Zhou
> Sent: Friday, December 20, 2013 21:03
> To: Pravin Shelar
&g
: Friday, December 20, 2013 21:03
To: Pravin Shelar
Cc: d...@openvswitch.com
Subject: Re: [ovs-dev] [PATCH] datapath: Fix sparse warning on
BUILD_BUG_ON_INVALID()
Thanks, pushed to the master.
On Fri, Dec 20, 2013 at 5:34 PM, Pravin Shelar wrote:
After chatting with Andy offline, it looks good to me
Thanks, pushed to the master.
On Fri, Dec 20, 2013 at 5:34 PM, Pravin Shelar wrote:
> After chatting with Andy offline, it looks good to me.
>
> Acked-by: Pravin B Shelar
>
> On Fri, Dec 20, 2013 at 5:19 PM, Pravin Shelar wrote:
> > On Fri, Dec 20, 2013 at 4:25 PM, Andy Zhou wrote:
> >> Spar
After chatting with Andy offline, it looks good to me.
Acked-by: Pravin B Shelar
On Fri, Dec 20, 2013 at 5:19 PM, Pravin Shelar wrote:
> On Fri, Dec 20, 2013 at 4:25 PM, Andy Zhou wrote:
>> Sparse gives the following warnings when compile against Linux kernel
>> 3.5:
>>
>> CHECK /root/projs
On Fri, Dec 20, 2013 at 4:25 PM, Andy Zhou wrote:
> Sparse gives the following warnings when compile against Linux kernel
> 3.5:
>
> CHECK /root/projs/ovs/openvswitch/datapath/linux/skbuff-openvswitch.c
> include/linux/mm.h:405:9: error: undefined identifier
> 'BUILD_BUG_ON_INVALID'
> includ
Sparse gives the following warnings when compile against Linux kernel
3.5:
CHECK /root/projs/ovs/openvswitch/datapath/linux/skbuff-openvswitch.c
include/linux/mm.h:405:9: error: undefined identifier
'BUILD_BUG_ON_INVALID'
include/linux/mm.h:405:9: error: not a function
The same issues may
Pushed to master,
Jarno
On Dec 11, 2013, at 10:53 AM, Pravin Shelar wrote:
> On Wed, Dec 11, 2013 at 10:51 AM, Jarno Rajahalme
> wrote:
>> Make the new compat function skb_flow_get_ports() static to silence a
>> sparse warning.
>>
>> Signed-off-by: Jarno Rajahalme
>> ---
>> datapath/linux
On Wed, Dec 11, 2013 at 10:51 AM, Jarno Rajahalme wrote:
> Make the new compat function skb_flow_get_ports() static to silence a
> sparse warning.
>
> Signed-off-by: Jarno Rajahalme
> ---
> datapath/linux/compat/flow_dissector.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
Make the new compat function skb_flow_get_ports() static to silence a
sparse warning.
Signed-off-by: Jarno Rajahalme
---
datapath/linux/compat/flow_dissector.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/linux/compat/flow_dissector.c
b/datapath/linux/compat/f
On Fri, Oct 26, 2012 at 2:29 PM, Jesse Gross wrote:
> On Thu, Oct 25, 2012 at 1:28 PM, Pravin Shelar wrote:
>> On Thu, Oct 25, 2012 at 1:19 PM, Ben Pfaff wrote:
>>> On Sat, Oct 27, 2012 at 01:07:24PM -0700, Pravin B Shelar wrote:
Signed-off-by: Pravin B Shelar
>>>
>>> I'm curious, what war
On Thu, Oct 25, 2012 at 1:28 PM, Pravin Shelar wrote:
> On Thu, Oct 25, 2012 at 1:19 PM, Ben Pfaff wrote:
>> On Sat, Oct 27, 2012 at 01:07:24PM -0700, Pravin B Shelar wrote:
>>> Signed-off-by: Pravin B Shelar
>>
>> I'm curious, what warning does sparse give? (You could add this to
>> the commit
On Thu, Oct 25, 2012 at 01:28:02PM -0700, Pravin Shelar wrote:
> On Thu, Oct 25, 2012 at 1:19 PM, Ben Pfaff wrote:
> > On Sat, Oct 27, 2012 at 01:07:24PM -0700, Pravin B Shelar wrote:
> >> Signed-off-by: Pravin B Shelar
> >
> > I'm curious, what warning does sparse give? (You could add this to
>
On Thu, Oct 25, 2012 at 1:19 PM, Ben Pfaff wrote:
> On Sat, Oct 27, 2012 at 01:07:24PM -0700, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>
> I'm curious, what warning does sparse give? (You could add this to
> the commit message.)
>
This symbol was moved from kernel.h to bug.h in 3
On Sat, Oct 27, 2012 at 01:07:24PM -0700, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
I'm curious, what warning does sparse give? (You could add this to
the commit message.)
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://ope
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/include/linux/kernel.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/datapath/linux/compat/include/linux/kernel.h
b/datapath/linux/compat/include/linux/kernel.h
index 812f213..ff354ad 100644
--- a/datapath/linux/compat/include/l
Thanks. Pushed to master.
On Thu, Jun 7, 2012 at 3:39 AM, Jesse Gross wrote:
> On Thu, Jun 7, 2012 at 4:00 AM, Pravin B Shelar wrote:
>> BUILD_BUG_ON_NOT_POWER_OF_2 could been defined in kernel.h or bug.h
>> depending on kernel version.
>>
>> Signed-off-by: Pravin B Shelar
>
> Acked-by: Jesse G
On Thu, Jun 7, 2012 at 4:00 AM, Pravin B Shelar wrote:
> BUILD_BUG_ON_NOT_POWER_OF_2 could been defined in kernel.h or bug.h
> depending on kernel version.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.o
BUILD_BUG_ON_NOT_POWER_OF_2 could been defined in kernel.h or bug.h
depending on kernel version.
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/include/linux/kernel.h |1 +
1 file changed, 1 insertion(+)
diff --git a/datapath/linux/compat/include/linux/kernel.h
b/datapath/linux/c
26 matches
Mail list logo
