Re: [ovs-dev] [PATCH] datapath: Fix panic sending IP frags over tunnels.

2016-01-20 Thread Joe Stringer
On 20 January 2016 at 14:12, pravin shelar wrote: > On Wed, Jan 20, 2016 at 12:41 PM, Joe Stringer wrote: > It is safer to do the same while de-fragmenting packets (handle_fragments()). Thanks, I rolled in your feedback and sent a v2. ___ dev mailing l

Re: [ovs-dev] [PATCH] datapath: Fix panic sending IP frags over tunnels.

2016-01-20 Thread pravin shelar
On Wed, Jan 20, 2016 at 12:41 PM, Joe Stringer wrote: > The entire OVS_GSO_CB was not preserved when performing fragmentation, > leading to the following NULL pointer dereference in ovs_stt_xmit(). Fix > this in the fragmentation handling code by preserving the whole CB. > > BUG: unable to handle

[ovs-dev] [PATCH] datapath: Fix panic sending IP frags over tunnels.

2016-01-20 Thread Joe Stringer
The entire OVS_GSO_CB was not preserved when performing fragmentation, leading to the following NULL pointer dereference in ovs_stt_xmit(). Fix this in the fragmentation handling code by preserving the whole CB. BUG: unable to handle kernel NULL pointer dereference at 001c IP: [] ovs_s