Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-30 Thread Pravin Shelar
I updated commit and added comment and pushed patch to master and 2.1. Thanks, Pravin. On Thu, Jan 30, 2014 at 6:13 PM, Jesse Gross wrote: > On Wed, Jan 29, 2014 at 7:18 PM, Jesse Gross wrote: >> On Wed, Jan 29, 2014 at 4:42 PM, Pravin Shelar wrote: >>> On Wed, Jan 29, 2014 at 4:38 PM, Jesse G

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-30 Thread Jesse Gross
On Wed, Jan 29, 2014 at 7:18 PM, Jesse Gross wrote: > On Wed, Jan 29, 2014 at 4:42 PM, Pravin Shelar wrote: >> On Wed, Jan 29, 2014 at 4:38 PM, Jesse Gross wrote: >>> On Wed, Jan 29, 2014 at 4:35 PM, Pravin Shelar wrote: On Wed, Jan 29, 2014 at 4:21 PM, Jesse Gross wrote: > On Wed, Ja

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Andy Zhou
Pravin, It may be good to add a comment pointing out that we don't expect flow->mask to be valid when calling from the packet execute() context. On Wed, Jan 29, 2014 at 7:18 PM, Jesse Gross wrote: > On Wed, Jan 29, 2014 at 4:42 PM, Pravin Shelar wrote: > > On Wed, Jan 29, 2014 at 4:38 PM, Jess

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Jesse Gross
On Wed, Jan 29, 2014 at 4:42 PM, Pravin Shelar wrote: > On Wed, Jan 29, 2014 at 4:38 PM, Jesse Gross wrote: >> On Wed, Jan 29, 2014 at 4:35 PM, Pravin Shelar wrote: >>> On Wed, Jan 29, 2014 at 4:21 PM, Jesse Gross wrote: On Wed, Jan 29, 2014 at 11:22 AM, Pravin Shelar wrote: > On Wed,

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Pravin Shelar
On Wed, Jan 29, 2014 at 4:38 PM, Jesse Gross wrote: > On Wed, Jan 29, 2014 at 4:35 PM, Pravin Shelar wrote: >> On Wed, Jan 29, 2014 at 4:21 PM, Jesse Gross wrote: >>> On Wed, Jan 29, 2014 at 11:22 AM, Pravin Shelar wrote: On Wed, Jan 29, 2014 at 10:44 AM, Jesse Gross wrote: > On Wed,

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Jesse Gross
On Wed, Jan 29, 2014 at 4:35 PM, Pravin Shelar wrote: > On Wed, Jan 29, 2014 at 4:21 PM, Jesse Gross wrote: >> On Wed, Jan 29, 2014 at 11:22 AM, Pravin Shelar wrote: >>> On Wed, Jan 29, 2014 at 10:44 AM, Jesse Gross wrote: On Wed, Jan 29, 2014 at 9:20 AM, wrote: > From: Pravin >

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Pravin Shelar
On Wed, Jan 29, 2014 at 4:21 PM, Jesse Gross wrote: > On Wed, Jan 29, 2014 at 11:22 AM, Pravin Shelar wrote: >> On Wed, Jan 29, 2014 at 10:44 AM, Jesse Gross wrote: >>> On Wed, Jan 29, 2014 at 9:20 AM, wrote: From: Pravin ovs_flow_free() is not called under ovs-lock during pack

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Jesse Gross
On Wed, Jan 29, 2014 at 11:22 AM, Pravin Shelar wrote: > On Wed, Jan 29, 2014 at 10:44 AM, Jesse Gross wrote: >> On Wed, Jan 29, 2014 at 9:20 AM, wrote: >>> From: Pravin >>> >>> ovs_flow_free() is not called under ovs-lock during packet >>> execute path. Since packet execute does not touch flo

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Pravin Shelar
On Wed, Jan 29, 2014 at 10:44 AM, Jesse Gross wrote: > On Wed, Jan 29, 2014 at 9:20 AM, wrote: >> From: Pravin >> >> ovs_flow_free() is not called under ovs-lock during packet >> execute path. Since packet execute does not touch flow->mask, >> there is no need to take that lock either. So move

Re: [ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread Jesse Gross
On Wed, Jan 29, 2014 at 9:20 AM, wrote: > From: Pravin > > ovs_flow_free() is not called under ovs-lock during packet > execute path. Since packet execute does not touch flow->mask, > there is no need to take that lock either. So move assert in > case where flow->mask is checked. > > Found by co

[ovs-dev] [PATCH] datapath: Fix ovs_flow_free() ovs-lock assert.

2014-01-29 Thread pshelar
From: Pravin ovs_flow_free() is not called under ovs-lock during packet execute path. Since packet execute does not touch flow->mask, there is no need to take that lock either. So move assert in case where flow->mask is checked. Found by code inspection. Signed-off-by: Pravin B Shelar --- dat