Re: [ovs-dev] [PATCH] datapath: Fix flow table sparse RCU annotations.

2011-11-16 Thread Jesse Gross
On Wed, Nov 16, 2011 at 4:11 PM, Ben Pfaff wrote: > On Wed, Nov 16, 2011 at 04:13:21PM -0800, Jesse Gross wrote: >> Any other warnings that you see? > > Only: > /home/blp/db/_build/datapath/linux/actions.c:416:8: warning: symbol > 'loop_counters' was not declared. Should it be static? > I think w

Re: [ovs-dev] [PATCH] datapath: Fix flow table sparse RCU annotations.

2011-11-16 Thread Ben Pfaff
On Wed, Nov 16, 2011 at 04:13:21PM -0800, Jesse Gross wrote: > Any other warnings that you see? Only: /home/blp/db/_build/datapath/linux/actions.c:416:8: warning: symbol 'loop_counters' was not declared. Should it be static? I think we found out earlier that this one is difficult, at best, to av

Re: [ovs-dev] [PATCH] datapath: Fix flow table sparse RCU annotations.

2011-11-16 Thread Jesse Gross
On Wed, Nov 16, 2011 at 4:05 PM, Ben Pfaff wrote: > On Wed, Nov 16, 2011 at 04:04:55PM -0800, Ben Pfaff wrote: >> On Wed, Nov 16, 2011 at 04:05:56PM -0800, Jesse Gross wrote: >> > Some overzealous marking of pointers as __rcu caused sparse to flag >> > errors that only showed up on the upstream ke

Re: [ovs-dev] [PATCH] datapath: Fix flow table sparse RCU annotations.

2011-11-16 Thread Ben Pfaff
On Wed, Nov 16, 2011 at 04:04:55PM -0800, Ben Pfaff wrote: > On Wed, Nov 16, 2011 at 04:05:56PM -0800, Jesse Gross wrote: > > Some overzealous marking of pointers as __rcu caused sparse to flag > > errors that only showed up on the upstream kernel tree. > > > > Signed-off-by: Jesse Gross > > Act

Re: [ovs-dev] [PATCH] datapath: Fix flow table sparse RCU annotations.

2011-11-16 Thread Ben Pfaff
On Wed, Nov 16, 2011 at 04:05:56PM -0800, Jesse Gross wrote: > Some overzealous marking of pointers as __rcu caused sparse to flag > errors that only showed up on the upstream kernel tree. > > Signed-off-by: Jesse Gross Actually I've been seeing these for ages in my build tree. I assumed that y

[ovs-dev] [PATCH] datapath: Fix flow table sparse RCU annotations.

2011-11-16 Thread Jesse Gross
Some overzealous marking of pointers as __rcu caused sparse to flag errors that only showed up on the upstream kernel tree. Signed-off-by: Jesse Gross --- datapath/datapath.c |2 +- datapath/flow.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath/dat