Re: [ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-29 Thread Jesse Gross
On Fri, Aug 29, 2014 at 12:38 PM, Pravin Shelar wrote: > On Fri, Aug 15, 2014 at 11:18 AM, Jesse Gross wrote: >> The checksum of ICMPv6 packets uses the IP pseudoheader as part of >> the calculation, unlike ICMP in IPv4. This was not implemented, >> which means that modifying the IP addresses of

Re: [ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-29 Thread Pravin Shelar
On Fri, Aug 15, 2014 at 11:18 AM, Jesse Gross wrote: > The checksum of ICMPv6 packets uses the IP pseudoheader as part of > the calculation, unlike ICMP in IPv4. This was not implemented, > which means that modifying the IP addresses of an ICMPv6 packet > would cause the checksum to no longer be c

Re: [ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-29 Thread Pravin Shelar
On Fri, Aug 29, 2014 at 9:30 AM, Jesse Gross wrote: > On Fri, Aug 15, 2014 at 11:18 AM, Jesse Gross wrote: >> The checksum of ICMPv6 packets uses the IP pseudoheader as part of >> the calculation, unlike ICMP in IPv4. This was not implemented, >> which means that modifying the IP addresses of an

Re: [ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-29 Thread Jesse Gross
On Fri, Aug 15, 2014 at 11:18 AM, Jesse Gross wrote: > The checksum of ICMPv6 packets uses the IP pseudoheader as part of > the calculation, unlike ICMP in IPv4. This was not implemented, > which means that modifying the IP addresses of an ICMPv6 packet > would cause the checksum to no longer be c

[ovs-dev] [PATCH] datapath: Fix checksum calculation when modifying ICMPv6 packets.

2014-08-15 Thread Jesse Gross
The checksum of ICMPv6 packets uses the IP pseudoheader as part of the calculation, unlike ICMP in IPv4. This was not implemented, which means that modifying the IP addresses of an ICMPv6 packet would cause the checksum to no longer be correct as the psuedoheader did not match. Reported-by: Neal S