Re: [ovs-dev] [PATCH] datapath: Factor out common UDP tunnel handling code.

2013-06-25 Thread Jesse Gross
On Tue, Jun 25, 2013 at 4:35 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On May 7, 2013, at 21:55 , ext Pravin Shelar wrote: > >> On Tue, May 7, 2013 at 11:13 AM, Jarno Rajahalme >> wrote: >>> This reduces repeated code and makes it easier to add new UDP tunneling >>> protocols. >>> >> This

Re: [ovs-dev] [PATCH] datapath: Factor out common UDP tunnel handling code.

2013-06-25 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On May 7, 2013, at 21:55 , ext Pravin Shelar wrote: > On Tue, May 7, 2013 at 11:13 AM, Jarno Rajahalme > wrote: >> This reduces repeated code and makes it easier to add new UDP tunneling >> protocols. >> > This approach is different from what tunnel upstream patches does. > Since there is no li

Re: [ovs-dev] [PATCH] datapath: Factor out common UDP tunnel handling code.

2013-05-07 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On May 7, 2013, at 21:55 , ext Pravin Shelar wrote: > On Tue, May 7, 2013 at 11:13 AM, Jarno Rajahalme > wrote: >> This reduces repeated code and makes it easier to add new UDP tunneling >> protocols. >> > This approach is different from what tunnel upstream patches does. > Since there is no li

Re: [ovs-dev] [PATCH] datapath: Factor out common UDP tunnel handling code.

2013-05-07 Thread Pravin Shelar
On Tue, May 7, 2013 at 11:13 AM, Jarno Rajahalme wrote: > This reduces repeated code and makes it easier to add new UDP tunneling > protocols. > This approach is different from what tunnel upstream patches does. Since there is no lisp support in kernel, this patch will make ovs out of tree tunneli

Re: [ovs-dev] [PATCH] datapath: Factor out common UDP tunnel handling code.

2013-05-07 Thread Kyle Mestery (kmestery)
Just one minor nit, otherwise this is a nice cleanup Jarno! See below. On May 7, 2013, at 1:13 PM, Jarno Rajahalme wrote: > This reduces repeated code and makes it easier to add new UDP tunneling > protocols. > > Signed-off-by: Jarno Rajahalme > --- > datapath/tunnel.c | 126

Re: [ovs-dev] [PATCH] datapath: Factor out common UDP tunnel handling code.

2013-05-07 Thread Kyle Mestery (kmestery)
On May 7, 2013, at 1:13 PM, Jarno Rajahalme wrote: > This reduces repeated code and makes it easier to add new UDP tunneling > protocols. > I haven't reviewed this in detail yet, but when I tried to compile it on Fedora, it failed. The small incremental below fixes this on Fedora. I'll continu

[ovs-dev] [PATCH] datapath: Factor out common UDP tunnel handling code.

2013-05-07 Thread Jarno Rajahalme
This reduces repeated code and makes it easier to add new UDP tunneling protocols. Signed-off-by: Jarno Rajahalme --- datapath/tunnel.c | 126 datapath/tunnel.h | 48 ++ datapath/vport-lisp.c | 167 --