Re: [ovs-dev] [PATCH] datapath: Convert dp rcu read operation to locked operations

2014-11-04 Thread Pravin Shelar
On Tue, Nov 4, 2014 at 12:39 PM, Andy Zhou wrote: > Looks good. Acked-by: Andy Zhou > > It would be to nice add more details to the commit message. The actual > problem occurs when ovs_dp_name() is called. > I pushed this fix to master. > In the long run, it would be nice to add lock depends to

Re: [ovs-dev] [PATCH] datapath: Convert dp rcu read operation to locked operations

2014-11-04 Thread Andy Zhou
Looks good. Acked-by: Andy Zhou It would be to nice add more details to the commit message. The actual problem occurs when ovs_dp_name() is called. In the long run, it would be nice to add lock depends to lookup_datapath. It seems all the use cases requires mutex to be held to prevent related d

[ovs-dev] [PATCH] datapath: Convert dp rcu read operation to locked operations

2014-10-29 Thread Pravin B Shelar
dp read operations depends on ovs_dp_cmd_fill_info(). This API needs to looup vport to find dp name, but vport lookup can fail. Therefore to keep vport reference alive we need to take ovs lock. Found by code inspection. Signed-off-by: Pravin B Shelar --- datapath/datapath.c | 12 ++-- 1