Re: [ovs-dev] [PATCH] datapath: Better handle vlan packets sent to userspace.

2011-11-18 Thread Jesse Gross
On Fri, Nov 18, 2011 at 1:57 PM, Ben Pfaff wrote: > On Thu, Nov 17, 2011 at 04:05:00PM -0800, Jesse Gross wrote: >> We no longer clone packets that are sent via the userspace action >> because placing them in Netlink attributes makes a copy so we >> generally don't touch the original.  The one exc

Re: [ovs-dev] [PATCH] datapath: Better handle vlan packets sent to userspace.

2011-11-18 Thread Ben Pfaff
On Thu, Nov 17, 2011 at 04:05:00PM -0800, Jesse Gross wrote: > We no longer clone packets that are sent via the userspace action > because placing them in Netlink attributes makes a copy so we > generally don't touch the original. The one exception to this is > accelerated vlan tags, which are cur

Re: [ovs-dev] [PATCH] datapath: Better handle vlan packets sent to userspace.

2011-11-17 Thread Brian Haley
On 11/17/2011 09:07 PM, Jesse Gross wrote: > On Thu, Nov 17, 2011 at 5:45 PM, Brian Haley wrote: >> On 11/17/2011 07:05 PM, Jesse Gross wrote: >>> diff --git a/datapath/datapath.c b/datapath/datapath.c >>> index c43adf9..4a51da6 100644 >>> --- a/datapath/datapath.c >>> +++ b/datapath/datapath.c >>

Re: [ovs-dev] [PATCH] datapath: Better handle vlan packets sent to userspace.

2011-11-17 Thread Jesse Gross
On Thu, Nov 17, 2011 at 5:45 PM, Brian Haley wrote: > On 11/17/2011 07:05 PM, Jesse Gross wrote: >> diff --git a/datapath/datapath.c b/datapath/datapath.c >> index c43adf9..4a51da6 100644 >> --- a/datapath/datapath.c >> +++ b/datapath/datapath.c >> @@ -437,17 +437,28 @@ static int queue_userspace_

Re: [ovs-dev] [PATCH] datapath: Better handle vlan packets sent to userspace.

2011-11-17 Thread Brian Haley
On 11/17/2011 07:05 PM, Jesse Gross wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index c43adf9..4a51da6 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -437,17 +437,28 @@ static int queue_userspace_packet(int dp_ifindex, > struct sk_buff *skb, >

[ovs-dev] [PATCH] datapath: Better handle vlan packets sent to userspace.

2011-11-17 Thread Jesse Gross
We no longer clone packets that are sent via the userspace action because placing them in Netlink attributes makes a copy so we generally don't touch the original. The one exception to this is accelerated vlan tags, which are currently inserted into the original packet as long as it isn't cloned.