On 8/8/14, 4:46 PM, "Andy Zhou" wrote:
>On Fri, Aug 8, 2014 at 3:58 PM, Pravin Shelar wrote:
>> On Fri, Aug 8, 2014 at 1:56 PM, Andy Zhou wrote:
>>> I agree with Daniele's comments.
>>>
>>> Acked-by: Andy Zhou
>>>
>> Thanks I pushed patch to master.
>>
>>> mask_set_nlattr() seems to have a s
On Fri, Aug 8, 2014 at 3:58 PM, Pravin Shelar wrote:
> On Fri, Aug 8, 2014 at 1:56 PM, Andy Zhou wrote:
>> I agree with Daniele's comments.
>>
>> Acked-by: Andy Zhou
>>
> Thanks I pushed patch to master.
>
>> mask_set_nlattr() seems to have a single user. may be we cna remove
>> this function an
On Fri, Aug 8, 2014 at 1:56 PM, Andy Zhou wrote:
> I agree with Daniele's comments.
>
> Acked-by: Andy Zhou
>
Thanks I pushed patch to master.
> mask_set_nlattr() seems to have a single user. may be we cna remove
> this function and
> call set_nlattr() directly?
>
> Not part of this patch, but s
I agree with Daniele's comments.
Acked-by: Andy Zhou
mask_set_nlattr() seems to have a single user. may be we cna remove
this function and
call set_nlattr() directly?
Not part of this patch, but set_nlattr() does not look correct in
handling nested attributes.
On Fri, Aug 8, 2014 at 9:25 AM,
Hi Pravin,
couple of comments:
- I would remove also the check for match->mask in update_range__().
- I think braces are not necessary for if/else statements in the macros.
Of course I would wait for review by Jesse or Andy, but other than that,
LGTM.
Acked-by: Daniele Di Proietto
On 8/7/14,
OVS does mask validation even if it does not need to convert
netlink mask attributes to mask structure. ovs_nla_get_match()
caller can pass NULL mask structure pointer if the caller does
not need mask. Therefore NULL check is required in SW_FLOW_KEY*
macros. Following patch does not convert mask
