Re: [ovs-dev] [PATCH] datapath: Add mask check during flow lookup

Thanks, that makes sense. On Mon, Jul 22, 2013 at 12:51 PM, Andy Zhou wrote: > The actual case I found this bug is more complicated to explain, but the > following made up example can illustrate the problem. Consider we have 2 > kernel mega flows: > > 1) in_port(1/0x), * > 2) in_port(2/0xf

Re: [ovs-dev] [PATCH] datapath: Add mask check during flow lookup

The actual case I found this bug is more complicated to explain, but the following made up example can illustrate the problem. Consider we have 2 kernel mega flows: 1) in_port(1/0x), * 2) in_port(2/0x), src_ip(1.1.1.1/255.255.255.255) They are not overlapping flows, however, when the

Re: [ovs-dev] [PATCH] datapath: Add mask check during flow lookup

On Fri, Jul 19, 2013 at 11:11 AM, Andy Zhou wrote: > A mega flow matches when the masked key matches and the mask applied > is the same as the mask used to create the mega flow. > > This patch adds the implementation of the second match condition > mentioned above. Without this fix, mega flow look

Re: [ovs-dev] [PATCH] datapath: Add mask check during flow lookup

Thanks, I pushed patch to master. On Fri, Jul 19, 2013 at 2:29 PM, Andy Zhou wrote: > Thanks Pravin. > > > On Fri, Jul 19, 2013 at 2:20 PM, Pravin Shelar wrote: >> >> On Fri, Jul 19, 2013 at 11:11 AM, Andy Zhou wrote: >> > A mega flow matches when the masked key matches and the mask applied >>

Re: [ovs-dev] [PATCH] datapath: Add mask check during flow lookup

Thanks Pravin. On Fri, Jul 19, 2013 at 2:20 PM, Pravin Shelar wrote: > On Fri, Jul 19, 2013 at 11:11 AM, Andy Zhou wrote: > > A mega flow matches when the masked key matches and the mask applied > > is the same as the mask used to create the mega flow. > > > > This patch adds the implementatio

Re: [ovs-dev] [PATCH] datapath: Add mask check during flow lookup

On Fri, Jul 19, 2013 at 11:11 AM, Andy Zhou wrote: > A mega flow matches when the masked key matches and the mask applied > is the same as the mask used to create the mega flow. > > This patch adds the implementation of the second match condition > mentioned above. Without this fix, mega flow look

[ovs-dev] [PATCH] datapath: Add mask check during flow lookup

A mega flow matches when the masked key matches and the mask applied is the same as the mask used to create the mega flow. This patch adds the implementation of the second match condition mentioned above. Without this fix, mega flow lookup may result false match. Bug #18584 Signed-off-by: Andy Z