On Tue, Jun 11, 2013 at 11:35 PM, Simon Horman wrote:
> On Tue, Jun 11, 2013 at 02:26:32PM -0700, Jesse Gross wrote:
>> When looking at this, I had an additional thought: different versions
>> of OpenFlow define the tag order differently and there is some limited
>> flexibility in how they get app
On Wed, Jun 12, 2013 at 11:00:56PM -0700, Pravin Shelar wrote:
> On Wed, Jun 12, 2013 at 6:19 PM, Simon Horman wrote:
> > On Wed, Jun 12, 2013 at 06:14:07PM -0700, Pravin Shelar wrote:
> >> On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote:
> >> > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman w
On Wed, Jun 12, 2013 at 6:19 PM, Simon Horman wrote:
> On Wed, Jun 12, 2013 at 06:14:07PM -0700, Pravin Shelar wrote:
>> On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote:
>> > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote:
>> >> @@ -341,10 +376,14 @@ static int netdev_send(struct vport
On Wed, Jun 12, 2013 at 06:14:07PM -0700, Pravin Shelar wrote:
> On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote:
> > On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote:
> >> diff --git a/datapath/actions.c b/datapath/actions.c
> >> index 0dac658..197811a 100644
> >> --- a/datapath/actions.c
On Tue, Jun 11, 2013 at 2:26 PM, Jesse Gross wrote:
> On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote:
>> diff --git a/datapath/actions.c b/datapath/actions.c
>> index 0dac658..197811a 100644
>> --- a/datapath/actions.c
>> +++ b/datapath/actions.c
>> +static int push_mpls(struct sk_buff *skb,
On Tue, Jun 11, 2013 at 02:26:32PM -0700, Jesse Gross wrote:
> On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote:
> > diff --git a/datapath/actions.c b/datapath/actions.c
> > index 0dac658..197811a 100644
> > --- a/datapath/actions.c
> > +++ b/datapath/actions.c
> > +static int push_mpls(struct
On Mon, Jun 10, 2013 at 1:07 AM, Simon Horman wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 0dac658..197811a 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> +static int push_mpls(struct sk_buff *skb,
> +const struct ovs_action_push_mpls *m
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Simon Horman
---
This is the r
On Thu, Apr 25, 2013 at 11:28:18AM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Apr 25, 2013, at 14:02 , ext Simon Horman wrote:
> >
> > Yes, stack_len is supposed to advance by one for each iteration of the loop.
>
> Better make it by four instead ;-)
Yes :-)
___
On Apr 25, 2013, at 14:02 , ext Simon Horman wrote:
>
> Yes, stack_len is supposed to advance by one for each iteration of the loop.
Better make it by four instead ;-)
Jarno
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/lis
On Thu, Apr 25, 2013 at 10:02:49AM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Apr 25, 2013, at 10:58 , ext Simon Horman wrote:
>
> > @@ -648,6 +650,7 @@ int ovs_flow_extract(struct sk_buff *skb, u16 in_port,
> > struct sw_flow_key *key,
> > return -ENOMEM;
> >
> > s
On Apr 25, 2013, at 10:58 , ext Simon Horman wrote:
> @@ -648,6 +650,7 @@ int ovs_flow_extract(struct sk_buff *skb, u16 in_port,
> struct sw_flow_key *key,
> return -ENOMEM;
>
> skb_reset_network_header(skb);
> + skb_reset_mac_len(skb);
> __skb_push(skb, skb->data
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Ravi K
Cc: Leo Alterman
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
This is the remaining
On Sat, Apr 20, 2013 at 06:25:03AM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Apr 19, 2013, at 10:41 , ext Simon Horman wrote:
>
> > diff --git a/datapath/actions.c b/datapath/actions.c
> > index 0dac658..2c923be 100644
> > --- a/datapath/actions.c
> > +++ b/datapath/actions.c
> > @@
On Apr 19, 2013, at 10:41 , ext Simon Horman wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 0dac658..2c923be 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> @@ -38,6 +38,7 @@
> #include "vport.h"
>
> static int do_execute_actions(struct datapath *dp, struct
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Ravi K
Cc: Leo Alterman
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
This is the remaining
On Mon, Oct 08, 2012 at 05:18:23PM -0700, Jesse Gross wrote:
> On Fri, Oct 5, 2012 at 12:20 AM, Simon Horman wrote:
> > On Wed, Oct 03, 2012 at 12:17:16PM -0700, Jesse Gross wrote:
> >> From: Leo Alterman
> >>
> >> Allow datapath to recognize and extract MPLS labels into flow keys
> >> and execut
On Fri, Oct 5, 2012 at 12:20 AM, Simon Horman wrote:
> On Wed, Oct 03, 2012 at 12:17:16PM -0700, Jesse Gross wrote:
>> From: Leo Alterman
>>
>> Allow datapath to recognize and extract MPLS labels into flow keys
>> and execute actions which push, pop, and set labels on packets.
>
> Hi,
>
> I now h
On Wed, Oct 03, 2012 at 12:17:16PM -0700, Jesse Gross wrote:
> From: Leo Alterman
>
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set labels on packets.
Hi,
I now have this code working in conjunction with a modified
version of R
On Thu, Oct 04, 2012 at 08:52:52AM -0700, Jesse Gross wrote:
> On Thu, Oct 4, 2012 at 1:58 AM, Simon Horman wrote:
> > On Wed, Oct 03, 2012 at 12:17:16PM -0700, Jesse Gross wrote:
> >> From: Leo Alterman
> >>
> >> Allow datapath to recognize and extract MPLS labels into flow keys
> >> and execute
On Thu, Oct 4, 2012 at 1:58 AM, Simon Horman wrote:
> On Wed, Oct 03, 2012 at 12:17:16PM -0700, Jesse Gross wrote:
>> From: Leo Alterman
>>
>> Allow datapath to recognize and extract MPLS labels into flow keys
>> and execute actions which push, pop, and set labels on packets.
>>
>> Signed-off-by:
On Wed, Oct 03, 2012 at 12:17:16PM -0700, Jesse Gross wrote:
> From: Leo Alterman
>
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set labels on packets.
>
> Signed-off-by: Leo Alterman
Hi,
As a method of reviewing this I've be
This patch looks very similar to the ones I had posted earlier albeit one
key difference being a variable added in ovs_skb_cb and obvious difference
in offset calculation code which is done based on this field. Some questions
1. Functions in this patch have similar issues which my initial patch ha
From: Leo Alterman
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Signed-off-by: Leo Alterman
--
I haven't reviewed this but hopefully it can be used a good starting point.
---
datapath/actions.c | 8
24 matches
Mail list logo
