Re: [ovs-dev] [PATCH] daemon: Avoid leaking socket fd in daemonize_start()

2011-09-05 Thread Ben Pfaff
On Mon, Sep 05, 2011 at 02:34:58PM +0900, Simon Horman wrote: > On Sun, Sep 04, 2011 at 09:38:29PM -0700, Ben Pfaff wrote: > > On Mon, Sep 05, 2011 at 11:15:25AM +0900, Simon Horman wrote: > > > When a daemon is set to monitor then saved_daemonize_id > > > needs to be closed in both the monitor and

Re: [ovs-dev] [PATCH] daemon: Avoid leaking socket fd in daemonize_start()

2011-09-04 Thread Simon Horman
On Sun, Sep 04, 2011 at 09:38:29PM -0700, Ben Pfaff wrote: > On Mon, Sep 05, 2011 at 11:15:25AM +0900, Simon Horman wrote: > > When a daemon is set to monitor then saved_daemonize_id > > needs to be closed in both the monitor and daemon processes > > to avoid a leaking a file descriptor. This patch

Re: [ovs-dev] [PATCH] daemon: Avoid leaking socket fd in daemonize_start()

2011-09-04 Thread Ben Pfaff
On Mon, Sep 05, 2011 at 11:15:25AM +0900, Simon Horman wrote: > When a daemon is set to monitor then saved_daemonize_id > needs to be closed in both the monitor and daemon processes > to avoid a leaking a file descriptor. This patch adds the latter. Needs { } around the close() call. I haven't re

[ovs-dev] [PATCH] daemon: Avoid leaking socket fd in daemonize_start()

2011-09-04 Thread Simon Horman
When a daemon is set to monitor then saved_daemonize_id needs to be closed in both the monitor and daemon processes to avoid a leaking a file descriptor. This patch adds the latter. --- lib/daemon.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/daemon.c b/lib/daemon