Re: [ovs-dev] [PATCH] command-line: Add function to print all options.

2014-10-16 Thread Ben Pfaff
On Thu, Oct 16, 2014 at 03:30:15PM -0700, Alex Wang wrote: > On Thu, Oct 16, 2014 at 3:20 PM, Ben Pfaff wrote: > > > I understand now. > > > > I agree that it makes sense to have a way to print the usage in an > > easily parsed way. But I don't think that making --help and "help" do > > differen

Re: [ovs-dev] [PATCH] command-line: Add function to print all options.

2014-10-16 Thread Alex Wang
On Thu, Oct 16, 2014 at 3:20 PM, Ben Pfaff wrote: > I understand now. > > I agree that it makes sense to have a way to print the usage in an > easily parsed way. But I don't think that making --help and "help" do > different things is a good distinction, because both forms are common > ways to g

Re: [ovs-dev] [PATCH] command-line: Add function to print all options.

2014-10-16 Thread Ben Pfaff
I understand now. I agree that it makes sense to have a way to print the usage in an easily parsed way. But I don't think that making --help and "help" do different things is a good distinction, because both forms are common ways to get a program to give human-readable help. How about using a di

Re: [ovs-dev] [PATCH] command-line: Add function to print all options.

2014-10-16 Thread Alex Wang
Sorry for the confusion, I mean: `command --help (or -h)` still prints out the usage page, `command help` prints the function format (usage). What do you think? Thanks, Alex Wang, On Thu, Oct 16, 2014 at 2:41 PM, Ben Pfaff wrote: > On Wed, Oct 15, 2014 at 09:51:54AM -0700, Alex Wang wrote:

Re: [ovs-dev] [PATCH] command-line: Add function to print all options.

2014-10-16 Thread Ben Pfaff
On Wed, Oct 15, 2014 at 09:51:54AM -0700, Alex Wang wrote: > I'm changing the 'struct command' like this: > > diff --git a/lib/command-line.h b/lib/command-line.h > index 157cb58..57fdff5 100644 > --- a/lib/command-line.h > +++ b/lib/command-line.h > @@ -27,7 +27,7 @@ struct command { > const

Re: [ovs-dev] [PATCH] command-line: Add function to print all options.

2014-10-15 Thread Alex Wang
Thx for the review, I adopted all your suggestions, I'm extending the bash completion to maybe all ovs-* cmds except ovs-vsctl. I'm changing the 'struct command' like this: diff --git a/lib/command-line.h b/lib/command-line.h index 157cb58..57fdff5 100644 --- a/lib/command-line.h +++ b/lib/comm

Re: [ovs-dev] [PATCH] command-line: Add function to print all options.

2014-09-15 Thread Ben Pfaff
On Thu, Sep 11, 2014 at 05:38:21PM -0700, Alex Wang wrote: > This commit adds function that extracts (both long and short) > options and returns them as string. Right now, only ovs-appctl > command provides an option to print this function output. And > the output is to be used by bash command-li

[ovs-dev] [PATCH] command-line: Add function to print all options.

2014-09-11 Thread Alex Wang
This commit adds function that extracts (both long and short) options and returns them as string. Right now, only ovs-appctl command provides an option to print this function output. And the output is to be used by bash command-line completion script for completion other options of the same comma