Re: [ovs-dev] [PATCH] classifier: Simplify versioning.

2015-06-12 Thread Gurucharan Shetty
On Thu, Jun 11, 2015 at 6:20 PM, Jarno Rajahalme wrote: > >> On Jun 11, 2015, at 5:58 PM, Jarno Rajahalme wrote: >> >> >>> On Jun 11, 2015, at 5:51 PM, Gurucharan Shetty wrote: >>> >>> On Thu, Jun 11, 2015 at 5:07 PM, Jarno Rajahalme >>> wrote: > On Jun 11, 2015, at 16:53, Ben Pf

Re: [ovs-dev] [PATCH] classifier: Simplify versioning.

2015-06-11 Thread Jarno Rajahalme
> On Jun 11, 2015, at 5:58 PM, Jarno Rajahalme wrote: > > >> On Jun 11, 2015, at 5:51 PM, Gurucharan Shetty wrote: >> >> On Thu, Jun 11, 2015 at 5:07 PM, Jarno Rajahalme >> wrote: >>> >>> On Jun 11, 2015, at 16:53, Ben Pfaff wrote: > On Thu, Jun 11, 2015 at 04:45:31PM -070

Re: [ovs-dev] [PATCH] classifier: Simplify versioning.

2015-06-11 Thread Jarno Rajahalme
> On Jun 11, 2015, at 5:51 PM, Gurucharan Shetty wrote: > > On Thu, Jun 11, 2015 at 5:07 PM, Jarno Rajahalme > wrote: >> >> >>> On Jun 11, 2015, at 16:53, Ben Pfaff wrote: >>> On Thu, Jun 11, 2015 at 04:45:31PM -0700, Jarno Rajahalme wrote: Also, avoid using type larger than int

Re: [ovs-dev] [PATCH] classifier: Simplify versioning.

2015-06-11 Thread Gurucharan Shetty
On Thu, Jun 11, 2015 at 5:07 PM, Jarno Rajahalme wrote: > > >> On Jun 11, 2015, at 16:53, Ben Pfaff wrote: >> >>> On Thu, Jun 11, 2015 at 04:45:31PM -0700, Jarno Rajahalme wrote: >>> Also, avoid using type larger than int in an enum, as it is not >>> portable C. >> >> Did we establish that that w

Re: [ovs-dev] [PATCH] classifier: Simplify versioning.

2015-06-11 Thread Jarno Rajahalme
> On Jun 11, 2015, at 16:53, Ben Pfaff wrote: > >> On Thu, Jun 11, 2015 at 04:45:31PM -0700, Jarno Rajahalme wrote: >> Also, avoid using type larger than int in an enum, as it is not >> portable C. > > Did we establish that that was the problem? Haven't heard from Guru yet, took your word for

Re: [ovs-dev] [PATCH] classifier: Simplify versioning.

2015-06-11 Thread Ben Pfaff
On Thu, Jun 11, 2015 at 04:45:31PM -0700, Jarno Rajahalme wrote: > Also, avoid using type larger than int in an enum, as it is not > portable C. Did we establish that that was the problem? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/m

[ovs-dev] [PATCH] classifier: Simplify versioning.

2015-06-11 Thread Jarno Rajahalme
After all, there are some cases in which both the insertion version and removal version of a rule need to be considered. This makes the cls_match a bit bigger, but makes classifier versioning much simpler to understand. Also, avoid using type larger than int in an enum, as it is not portable C.