Re: [ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 4:14 PM, Ben Pfaff wrote: > On Thu, Mar 24, 2016 at 03:35:33PM -0400, Russell Bryant wrote: > > I think the python directory should be limited to what we consider the > ovs > > Python library. That's largely what it is, except for the build/ and > > ovstest/ directories.

Re: [ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Ben Pfaff
On Thu, Mar 24, 2016 at 03:35:33PM -0400, Russell Bryant wrote: > I think the python directory should be limited to what we consider the ovs > Python library. That's largely what it is, except for the build/ and > ovstest/ directories. Going off on a tangent: should those be somewhere else, then,

Re: [ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Russell Bryant
On Thu, Mar 24, 2016 at 2:23 PM, Aaron Conole wrote: > Most projects have a checkpatch facility, which can be used as a pre-commit > sanity check. This introduces such a mechanism to the Open vSwitch project > to catch some of the more silly formatting mistakes which can occur. It is > not meant

[ovs-dev] [PATCH] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Aaron Conole
Most projects have a checkpatch facility, which can be used as a pre-commit sanity check. This introduces such a mechanism to the Open vSwitch project to catch some of the more silly formatting mistakes which can occur. It is not meant to replace good code review practices, but it can help eliminat