Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ben Pfaff
On Wed, Jul 18, 2012 at 11:54:55PM -0700, Ethan Jackson wrote: > This patch makes a two improvements to CFM logging which should > make debugging connectivity problems a bit more intuitive. First, > when a remote_mp disappears, the length of time since its last CCM > reception is logged. Second,

[ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ethan Jackson
This patch makes a two improvements to CFM logging which should make debugging connectivity problems a bit more intuitive. First, when a remote_mp disappears, the length of time since its last CCM reception is logged. Second, the "CFM fault status changed" message is reformatted in a more intuiti

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ethan Jackson
> I do think that's an improvement. One more tweak: how about "CFM > faults" instead of "CFM fault status". To me the former more clearly > implies that everything in each list is a fault, whereas the latter > talks more vaguely about a "status". Sounds good, I'll tweak the patch and send out an

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ben Pfaff
I do think that's an improvement. One more tweak: how about "CFM faults" instead of "CFM fault status". To me the former more clearly implies that everything in each list is a fault, whereas the latter talks more vaguely about a "status". Thanks, Ben. On Fri, Jul 20, 2012 at 11:14:32AM -0700,

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ethan Jackson
I'm not sure what a better wording would be. Perhaps something like the following? CFM fault status changed from [] to [rdi interval]. The brakets make it clear that it's a list. Ethan On Thu, Jul 19, 2012 at 8:12 PM, Ben Pfaff wrote: > On Wed, Jul 18, 2012 at 09:10:59PM -0700, Ethan Jackson

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-19 Thread Ben Pfaff
On Wed, Jul 18, 2012 at 09:10:59PM -0700, Ethan Jackson wrote: > This patch makes a two improvements to CFM logging which should > make debugging connectivity problems a more intuitive. First, when > a remote_mp disappears, the length of time since its last CCM > reception is logged. Second, the

[ovs-dev] [PATCH] cfm: Improve logging.

2012-07-19 Thread Ethan Jackson
This patch makes a two improvements to CFM logging which should make debugging connectivity problems a more intuitive. First, when a remote_mp disappears, the length of time since its last CCM reception is logged. Second, the "CFM fault status changed" message is reformatted in a more intuitive w