Re: [ovs-dev] [PATCH] bridge.c: Invoke async_append_enable() in bridge_init()

2013-08-02 Thread Alex Wang
Yes, I'm doing that. On Fri, Aug 2, 2013 at 5:44 PM, Ethan Jackson wrote: > The commit message sounds good to me. Alex, would you be willing to > review it? > > Ethan > > On Fri, Aug 2, 2013 at 5:34 PM, Ben Pfaff wrote: > > I sent out a counterproposal: > > http://openvswitch.org/pipe

Re: [ovs-dev] [PATCH] bridge.c: Invoke async_append_enable() in bridge_init()

2013-08-02 Thread Ethan Jackson
The commit message sounds good to me. Alex, would you be willing to review it? Ethan On Fri, Aug 2, 2013 at 5:34 PM, Ben Pfaff wrote: > I sent out a counterproposal: > http://openvswitch.org/pipermail/dev/2013-August/030288.html > Please review it, if you have time. > > Is there a bug #

Re: [ovs-dev] [PATCH] bridge.c: Invoke async_append_enable() in bridge_init()

2013-08-02 Thread Ben Pfaff
I sent out a counterproposal: http://openvswitch.org/pipermail/dev/2013-August/030288.html Please review it, if you have time. Is there a bug # for this? If so, I will add it to the commit message. On Fri, Aug 02, 2013 at 04:47:39PM -0700, Alex Wang wrote: > No problem, I'm also not sure

Re: [ovs-dev] [PATCH] bridge.c: Invoke async_append_enable() in bridge_init()

2013-08-02 Thread Alex Wang
No problem, I'm also not sure if that is the right place or way. Thanks, Alex Wang, On Fri, Aug 2, 2013 at 4:45 PM, Ben Pfaff wrote: > On Fri, Aug 02, 2013 at 03:47:45PM -0700, Alex Wang wrote: > > Commit a5fb0e29a9c56 (vlog: Use async I/O.) invokes the function > > async_append_enable() in br

Re: [ovs-dev] [PATCH] bridge.c: Invoke async_append_enable() in bridge_init()

2013-08-02 Thread Ben Pfaff
On Fri, Aug 02, 2013 at 03:47:45PM -0700, Alex Wang wrote: > Commit a5fb0e29a9c56 (vlog: Use async I/O.) invokes the function > async_append_enable() in bridge_run(). This may cause the abortion > of ovs-vswitchd since async_append_enable() must be invoked while > single-threaded. And it is possibl

[ovs-dev] [PATCH] bridge.c: Invoke async_append_enable() in bridge_init()

2013-08-02 Thread Alex Wang
Commit a5fb0e29a9c56 (vlog: Use async I/O.) invokes the function async_append_enable() in bridge_run(). This may cause the abortion of ovs-vswitchd since async_append_enable() must be invoked while single-threaded. And it is possible that system-state.c spawns a thread before the invocation. This