Re: [ovs-dev] [PATCH] bridge: improve vlan mode related error messages when adding port

2014-04-09 Thread Thomas Graf
On 04/09/2014 06:57 PM, Ben Pfaff wrote: On Wed, Apr 09, 2014 at 09:52:03AM -0700, Ben Pfaff wrote: On Wed, Apr 09, 2014 at 05:19:17PM +0200, Thomas Graf wrote: Inform about fallback to trunk mode and convert errors to warnings when we are not failing. Signed-off-by: Thomas Graf I'm pretty

Re: [ovs-dev] [PATCH] bridge: improve vlan mode related error messages when adding port

2014-04-09 Thread Ben Pfaff
On Wed, Apr 09, 2014 at 09:52:03AM -0700, Ben Pfaff wrote: > On Wed, Apr 09, 2014 at 05:19:17PM +0200, Thomas Graf wrote: > > Inform about fallback to trunk mode and convert errors to warnings > > when we are not failing. > > > > Signed-off-by: Thomas Graf > > I'm pretty sure that the first one,

Re: [ovs-dev] [PATCH] bridge: improve vlan mode related error messages when adding port

2014-04-09 Thread Ben Pfaff
On Wed, Apr 09, 2014 at 05:19:17PM +0200, Thomas Graf wrote: > Inform about fallback to trunk mode and convert errors to warnings > when we are not failing. > > Signed-off-by: Thomas Graf I'm pretty sure that the first one, as the comment says, really can't happen. Have you been able to trigger

[ovs-dev] [PATCH] bridge: improve vlan mode related error messages when adding port

2014-04-09 Thread Thomas Graf
Inform about fallback to trunk mode and convert errors to warnings when we are not failing. Signed-off-by: Thomas Graf --- vswitchd/bridge.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 24b3602..c6095b2 100644 --- a/vswitchd