[ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

2012-08-10 Thread Ethan Jackson
There's currently no way to set the admin state on dummy netdevs. This patch provides a mechanism to do so which will be used in future unit tests. Signed-off-by: Ethan Jackson --- lib/netdev-dummy.c | 75 +- 1 file changed, 68 insertions(+), 7

Re: [ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

2012-08-10 Thread Ethan Jackson
> I kind of feel like it's a wart that should be confined to > netdev-dummy. That's fine, I could think of arguments either way and made a judgement call. I'll move the appctl command to netdev-dummy. Ethan > > s/ , /, / here, twice: >> +if (!strcasecmp(argv[argc - 1] , "up")) { >> +

Re: [ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 06:21:43PM -0700, Ethan Jackson wrote: > There's currently no way to set the admin state on dummy netdevs. > This patch provides a mechanism to do so that generalizes to all > netdevs cleanly. > > Signed-off-by: Ethan Jackson I have mixed feelings about this. From a broa

[ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

2012-08-09 Thread Ethan Jackson
There's currently no way to set the admin state on dummy netdevs. This patch provides a mechanism to do so that generalizes to all netdevs cleanly. Signed-off-by: Ethan Jackson --- vswitchd/bridge.c | 53 + 1 file changed, 53 insertions(+) dif