Re: [ovs-dev] [PATCH] bridge: Keep bond active slave selection across OVS restart

2014-10-06 Thread Alex Wang
> > > > > Not very familiar with the documentation format, > > > > Should we put bond_fake_iface inside 'status' column? Or we want to > allow > > user modify it? > > Do you mean bond_active_slave? Yes, put it in status colume makes more > sense. I will move it there. > > > Yes, I mean that. Thx

Re: [ovs-dev] [PATCH] bridge: Keep bond active slave selection across OVS restart

2014-10-06 Thread Andy Zhou
Alex, thanks for the review. I will push it in a minute, and back port to branch 2.3. On Mon, Oct 6, 2014 at 9:36 AM, Alex Wang wrote: > Thx for fixing this, > > >> >> +#include "lib/vswitch-idl.h" >> > > This could be removed, Done. > > >> >> VLOG_DEFINE_THIS_MODULE(bond); >> >> @@ -131,6 +132,

Re: [ovs-dev] [PATCH] bridge: Keep bond active slave selection across OVS restart

2014-10-06 Thread Alex Wang
Thx for fixing this, > +#include "lib/vswitch-idl.h" > > This could be removed, > VLOG_DEFINE_THIS_MODULE(bond); > > @@ -131,6 +132,15 @@ struct bond { > uint32_t recirc_id; /* Non zero if recirculation can be > used.*/ > struct hmap pr_rule_ops; /* Helps to maintain p

[ovs-dev] [PATCH] bridge: Keep bond active slave selection across OVS restart

2014-10-06 Thread Andy Zhou
Whenever OVS restarts, it pseudo-randomly picks an interface of a bond port to be the active slave. This can cause traffic disruption in case the upstream switch does not support LACP, or in case of multi-chassis switches that do not support mLACP. This patch helps the situation by always record t