Re: [ovs-dev] [PATCH] bridge: Ignore "null" interfaces as required.

2012-05-21 Thread Ethan Jackson
Yep, I'll pull it back, if it's not trivial I'll send it out for review. Ethan On Mon, May 21, 2012 at 2:57 PM, Ben Pfaff wrote: > On Mon, May 21, 2012 at 01:27:47PM -0700, Ethan Jackson wrote: >> Commit bae7208e91a0 (bridge: Refactor bridge_reconfigure().) >> introduced a regression in which th

Re: [ovs-dev] [PATCH] bridge: Ignore "null" interfaces as required.

2012-05-21 Thread Ben Pfaff
On Mon, May 21, 2012 at 01:27:47PM -0700, Ethan Jackson wrote: > Commit bae7208e91a0 (bridge: Refactor bridge_reconfigure().) > introduced a regression in which the switch would attempt to > instantiate "null" interfaces in the datapath. This would, of > course, fail and trigger a warning. Though

[ovs-dev] [PATCH] bridge: Ignore "null" interfaces as required.

2012-05-21 Thread Ethan Jackson
Commit bae7208e91a0 (bridge: Refactor bridge_reconfigure().) introduced a regression in which the switch would attempt to instantiate "null" interfaces in the datapath. This would, of course, fail and trigger a warning. Though harmless, these warnings confused users. Signed-off-by: Ethan Jackson

Re: [ovs-dev] [PATCH] bridge: Ignore null interfaces as required.

2012-04-24 Thread Ethan Jackson
Thanks merged. Ethan On Tue, Apr 24, 2012 at 12:53, Ben Pfaff wrote: > On Mon, Apr 23, 2012 at 09:26:40AM -0700, Ethan Jackson wrote: >> This issue has been around for quite some time.  It doesn't really >> cause problems beyond some spurious warnings. >> >> Signed-off-by: Ethan Jackson > > Loo

Re: [ovs-dev] [PATCH] bridge: Ignore null interfaces as required.

2012-04-24 Thread Ben Pfaff
On Mon, Apr 23, 2012 at 09:26:40AM -0700, Ethan Jackson wrote: > This issue has been around for quite some time. It doesn't really > cause problems beyond some spurious warnings. > > Signed-off-by: Ethan Jackson Looks good, thank you. ___ dev mailing

[ovs-dev] [PATCH] bridge: Ignore null interfaces as required.

2012-04-24 Thread Ethan Jackson
This issue has been around for quite some time. It doesn't really cause problems beyond some spurious warnings. Signed-off-by: Ethan Jackson --- vswitchd/bridge.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 077d9ee..037a4cb