Re: [ovs-dev] [PATCH] bridge: Execute bridge_run() only after retrieving db contents.

2015-04-01 Thread Alex Wang
Thx, applied to master~ On Wed, Apr 1, 2015 at 5:02 PM, Ben Pfaff wrote: > Yes, I like that better, thanks! > > On Wed, Apr 01, 2015 at 04:59:42PM -0700, Alex Wang wrote: > > How about this? > > > > +} else if (!ovsdb_idl_has_lock(idl) > > + || !ovsdb_idl_has_ever_connected(idl

Re: [ovs-dev] [PATCH] bridge: Execute bridge_run() only after retrieving db contents.

2015-04-01 Thread Ben Pfaff
Yes, I like that better, thanks! On Wed, Apr 01, 2015 at 04:59:42PM -0700, Alex Wang wrote: > How about this? > > +} else if (!ovsdb_idl_has_lock(idl) > + || !ovsdb_idl_has_ever_connected(idl)) { > +/* Returns if not holding the lock or not done retrieving db > +

Re: [ovs-dev] [PATCH] bridge: Execute bridge_run() only after retrieving db contents.

2015-04-01 Thread Alex Wang
How about this? +} else if (!ovsdb_idl_has_lock(idl) + || !ovsdb_idl_has_ever_connected(idl)) { +/* Returns if not holding the lock or not done retrieving db + * contents. */ return; } On Wed, Apr 1, 2015 at 4:55 PM, Ben Pfaff wrote: > On Wed, Ap

Re: [ovs-dev] [PATCH] bridge: Execute bridge_run() only after retrieving db contents.

2015-04-01 Thread Ben Pfaff
On Wed, Apr 01, 2015 at 04:52:24PM -0700, Alex Wang wrote: > During upgrade of ovs-vswitchd, we do not want to recreate the kernel > interfaces. Especially when IP address is assigned to the internal port, > the recreation will cause the lost of connection. Therefore, ovs-vswitchd > should read c

[ovs-dev] [PATCH] bridge: Execute bridge_run() only after retrieving db contents.

2015-04-01 Thread Alex Wang
During upgrade of ovs-vswitchd, we do not want to recreate the kernel interfaces. Especially when IP address is assigned to the internal port, the recreation will cause the lost of connection. Therefore, ovs-vswitchd should read current ovsdb content first and then reuse the existing kernel inter