Re: [ovs-dev] [PATCH] bfd.at: Fix intermittent failure of test - flap_count.

2014-10-02 Thread Alex Wang
Thx, applied to master, On Thu, Oct 2, 2014 at 11:00 PM, Alex Wang wrote: > > > On Thu, Oct 2, 2014 at 6:29 PM, Joe Stringer > wrote: > >> Sounds good to me. Nice to hear confirmation from the overnight test. >> Might be worthwhile adding a short note above the line to explain that >> reducing

Re: [ovs-dev] [PATCH] bfd.at: Fix intermittent failure of test - flap_count.

2014-10-02 Thread Alex Wang
On Thu, Oct 2, 2014 at 6:29 PM, Joe Stringer wrote: > Sounds good to me. Nice to hear confirmation from the overnight test. > Might be worthwhile adding a short note above the line to explain that > reducing the update interval prevents particular race conditions. > Thx for the suggestion, I'll

Re: [ovs-dev] [PATCH] bfd.at: Fix intermittent failure of test - flap_count.

2014-10-02 Thread Joe Stringer
Sounds good to me. Nice to hear confirmation from the overnight test. Might be worthwhile adding a short note above the line to explain that reducing the update interval prevents particular race conditions. Did you consider applying the same change to the CFM flap_count test? Acked-by: Joe String

Re: [ovs-dev] [PATCH] bfd.at: Fix intermittent failure of test - flap_count.

2014-10-02 Thread Alex Wang
overnight run of the test in a loop on my vm did not cause any error. (it used to reproduce the failure every several minutes) On Wed, Oct 1, 2014 at 10:35 PM, Alex Wang wrote: > ovs-vsctl commands like 'ovs-vsctl list Interface p1' use the > 'monitor' RPC method, which causes ovsdb sending up

[ovs-dev] [PATCH] bfd.at: Fix intermittent failure of test - flap_count.

2014-10-01 Thread Alex Wang
ovs-vsctl commands like 'ovs-vsctl list Interface p1' use the 'monitor' RPC method, which causes ovsdb sending updates to the command session when changes are committed to the monitored table. Since ovs-vsctl commands are short-lived, there is chance that ovs-vsctl terminates the connection to ovs