Re: [ovs-dev] [PATCH] bashcomp: Install and package completion scripts.

2015-03-12 Thread Ben Pfaff
Fantastic! On Thu, Mar 12, 2015 at 05:01:57PM -0700, Alex Wang wrote: > Sure, just found this link, will try the '_get_comp_words_by_ref' and make > some magic, > > http://stackoverflow.com/questions/10528695/how-to-reset-comp-wordbreaks-without-effecting-other-completion-script > > Thanks, > Al

Re: [ovs-dev] [PATCH] bashcomp: Install and package completion scripts.

2015-03-12 Thread Alex Wang
Sure, just found this link, will try the '_get_comp_words_by_ref' and make some magic, http://stackoverflow.com/questions/10528695/how-to-reset-comp-wordbreaks-without-effecting-other-completion-script Thanks, Alex Wang, On Thu, Mar 12, 2015 at 4:42 PM, Ben Pfaff wrote: > Hmm, but it will make

Re: [ovs-dev] [PATCH] bashcomp: Install and package completion scripts.

2015-03-12 Thread Ben Pfaff
Hmm, but it will make the completion a lot less useful if every user has to enable it himself; hardly anyone will do that. Can you imagine any workarounds? On Thu, Mar 12, 2015 at 04:37:32PM -0700, Alex Wang wrote: > Yeah, the reason I did it this way is in that the ovs-vsctl-bashcomp.bash > scri

Re: [ovs-dev] [PATCH] bashcomp: Install and package completion scripts.

2015-03-12 Thread Alex Wang
Yeah, the reason I did it this way is in that the ovs-vsctl-bashcomp.bash script changes the $COMP_WORDBREAKS variable: """ export COMP_WORDBREAKS=" " """ This global variable contains the delimiter used by the bash completion for breaking the arguments. I'm a bit worried that this could cause th

Re: [ovs-dev] [PATCH] bashcomp: Install and package completion scripts.

2015-03-12 Thread Ben Pfaff
On Thu, Mar 12, 2015 at 03:34:48PM -0700, Alex Wang wrote: > This commit adds the bash completion scripts to scripts_SCRIPTS target > and makes sure they are packaged correctly. Note, the scripts will only > be placed at the directory for scripts so that users can get them if needed. > > Signed-o

[ovs-dev] [PATCH] bashcomp: Install and package completion scripts.

2015-03-12 Thread Alex Wang
This commit adds the bash completion scripts to scripts_SCRIPTS target and makes sure they are packaged correctly. Note, the scripts will only be placed at the directory for scripts so that users can get them if needed. Signed-off-by: Alex Wang --- debian/openvswitch-switch.install |2 ++ r