Re: [ovs-dev] [PATCH] bash_completion shouldn't modify user environment

2015-06-07 Thread Alex Wang
Sorry for missing this discussion, Yeah, this is the correct fix. I think I must have put it there since I wanted my own display to be sorted... But I should really do it in my own .bashrc. Will apply the patch soon, Acked-by: Alex Wang Thanks, Alex Wang, On Sun, Jun 7, 2015 at 11:16 AM, Be

Re: [ovs-dev] [PATCH] bash_completion shouldn't modify user environment

2015-06-07 Thread Ben Pfaff
[adding Alex, the author of the script] On Thu, May 28, 2015 at 10:57:42AM -0300, Flavio Leitner wrote: > On Thu, May 28, 2015 at 12:07:14PM +0800, Zang MingJie wrote: > > Signed-off-by: Zang MingJie > > --- > > utilities/ovs-appctl-bashcomp.bash | 5 + > > 1 file changed, 1 insertion(+), 4

Re: [ovs-dev] [PATCH] bash_completion shouldn't modify user environment

2015-05-28 Thread Flavio Leitner
On Thu, May 28, 2015 at 12:07:14PM +0800, Zang MingJie wrote: > Signed-off-by: Zang MingJie > --- > utilities/ovs-appctl-bashcomp.bash | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/utilities/ovs-appctl-bashcomp.bash > b/utilities/ovs-appctl-bashcomp.bash > index 6

[ovs-dev] [PATCH] bash_completion shouldn't modify user environment

2015-05-27 Thread Zang MingJie
Signed-off-by: Zang MingJie --- utilities/ovs-appctl-bashcomp.bash | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/utilities/ovs-appctl-bashcomp.bash b/utilities/ovs-appctl-bashcomp.bash index 67a268e..f7fb830 100755 --- a/utilities/ovs-appctl-bashcomp.bash +++ b/utilitie