Re: [ovs-dev] [PATCH] band.c: Fix error in bond_choose_output_slave() function.

2013-08-12 Thread Ben Pfaff
On Mon, Aug 12, 2013 at 02:06:54PM -0700, Alex Wang wrote: > On Mon, Aug 12, 2013 at 2:04 PM, Ben Pfaff wrote: > > > > > I am nervous about accessing anything in 'slave' outside the lock. > > What do you think of this variant? > > > > Thanks, > > > > Ben. > > > Thanks Ben, for pointing this out

Re: [ovs-dev] [PATCH] band.c: Fix error in bond_choose_output_slave() function.

2013-08-12 Thread Alex Wang
On Mon, Aug 12, 2013 at 2:04 PM, Ben Pfaff wrote: > > I am nervous about accessing anything in 'slave' outside the lock. > What do you think of this variant? > > Thanks, > > Ben. Thanks Ben, for pointing this out, Yours looks good and safer! ___ dev

Re: [ovs-dev] [PATCH] band.c: Fix error in bond_choose_output_slave() function.

2013-08-12 Thread Ben Pfaff
On Mon, Aug 12, 2013 at 02:14:52PM -0700, Alex Wang wrote: > This commit fixes the error introduced by commit 4a1b8f30e59 (bond: > Stop using tags.). The error is caused by mistakenly returning 'slave' > where 'slave->aux' should be returned. > > Signed-off-by: Alex Wang I am nervous about acces

[ovs-dev] [PATCH] band.c: Fix error in bond_choose_output_slave() function.

2013-08-12 Thread Alex Wang
This commit fixes the error introduced by commit 4a1b8f30e59 (bond: Stop using tags.). The error is caused by mistakenly returning 'slave' where 'slave->aux' should be returned. Signed-off-by: Alex Wang --- lib/bond.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bon