Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-13 Thread Yang, Yi
On Mon, Jun 13, 2016 at 10:59:36AM +0200, Jiri Benc wrote: > On Sun, 12 Jun 2016 20:53:23 +0800, Yang, Yi wrote: > > On Mon, Jun 06, 2016 at 02:22:58PM -0700, Jesse Gross wrote: > > > However, the changes to vport-vxlan.c are modifying compatibility code > > > that shouldn't be extended further. In

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-13 Thread Jiri Benc
On Sun, 12 Jun 2016 20:53:23 +0800, Yang, Yi wrote: > On Mon, Jun 06, 2016 at 02:22:58PM -0700, Jesse Gross wrote: > > However, the changes to vport-vxlan.c are modifying compatibility code > > that shouldn't be extended further. Instead, just use the existing > > VXLAN netlink interfaces that have

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-12 Thread Yang, Yi
On Mon, Jun 06, 2016 at 02:22:58PM -0700, Jesse Gross wrote: > On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: > [...] > > datapath/vport-netdev.c | 3 +- > > datapath/vport-vxlan.c| 17 ++- > > These changes aren't upstream yet. Please do t

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Hannes Frederic Sowa
On 09.06.2016 22:35, Alexander Duyck wrote: > On Thu, Jun 9, 2016 at 12:23 PM, Hannes Frederic Sowa > wrote: >> On 09.06.2016 18:14, Alexander Duyck wrote: >>> On Thu, Jun 9, 2016 at 3:57 AM, Hannes Frederic Sowa >>> wrote: On 09.06.2016 04:33, Alexander Duyck wrote: > On Wed, Jun 8, 2

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Alexander Duyck
On Thu, Jun 9, 2016 at 12:23 PM, Hannes Frederic Sowa wrote: > On 09.06.2016 18:14, Alexander Duyck wrote: >> On Thu, Jun 9, 2016 at 3:57 AM, Hannes Frederic Sowa >> wrote: >>> On 09.06.2016 04:33, Alexander Duyck wrote: On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa wrote: >>>

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Hannes Frederic Sowa
On 09.06.2016 18:14, Alexander Duyck wrote: > On Thu, Jun 9, 2016 at 3:57 AM, Hannes Frederic Sowa > wrote: >> On 09.06.2016 04:33, Alexander Duyck wrote: >>> On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa >>> wrote: The remaining problem regarding offloads would be, that we by defau

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Alexander Duyck
On Thu, Jun 9, 2016 at 1:14 AM, Jesse Gross wrote: > On Wed, Jun 8, 2016 at 7:33 PM, Alexander Duyck > wrote: >> Agreed, but what are we really getting by adding the port value? In >> the case of the Intel hardware it isn't much as I can take advantage >> of checksum offload if I just turn on th

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Alexander Duyck
On Thu, Jun 9, 2016 at 3:57 AM, Hannes Frederic Sowa wrote: > On 09.06.2016 04:33, Alexander Duyck wrote: >> On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa >> wrote: >>> The remaining problem regarding offloads would be, that we by default >>> get into the situation that without the specia

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Hannes Frederic Sowa
On 09.06.2016 04:33, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa > wrote: >> The remaining problem regarding offloads would be, that we by default >> get into the situation that without the special offloading rule the >> vxlan stream will only be processed on one

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Jesse Gross
On Wed, Jun 8, 2016 at 7:33 PM, Alexander Duyck wrote: > Agreed, but what are we really getting by adding the port value? In > the case of the Intel hardware it isn't much as I can take advantage > of checksum offload if I just turn on the outer headers. Then I don't > even need to enable the Rx

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Alexander Duyck
On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa wrote: > On 08.06.2016 23:21, Alexander Duyck wrote: >> On Wed, Jun 8, 2016 at 12:46 PM, Hannes Frederic Sowa >> wrote: >>> On 08.06.2016 17:38, Alexander Duyck wrote: On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa wrote: >>>

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Hannes Frederic Sowa
On 08.06.2016 23:21, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 12:46 PM, Hannes Frederic Sowa > wrote: >> On 08.06.2016 17:38, Alexander Duyck wrote: >>> On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa >>> wrote: On 08.06.2016 14:51, Jiri Benc wrote: > On Mon, 6 Jun 2016 14:

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Alexander Duyck
On Wed, Jun 8, 2016 at 12:46 PM, Hannes Frederic Sowa wrote: > On 08.06.2016 17:38, Alexander Duyck wrote: >> On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa >> wrote: >>> On 08.06.2016 14:51, Jiri Benc wrote: On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: > On Sat, Jun 4, 2

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Hannes Frederic Sowa
On 08.06.2016 17:38, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa > wrote: >> On 08.06.2016 14:51, Jiri Benc wrote: >>> On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: [...] > datapath/vport-netd

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Alexander Duyck
On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa wrote: > On 08.06.2016 14:51, Jiri Benc wrote: >> On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: >>> On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: >>> [...] datapath/vport-netdev.c | 3 +- datapath

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Hannes Frederic Sowa
On 08.06.2016 14:51, Jiri Benc wrote: > On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: >> On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: >> [...] >>> datapath/vport-netdev.c | 3 +- >>> datapath/vport-vxlan.c| 17 ++- >> >> These chan

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Jiri Benc
On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: > On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: > [...] > > datapath/vport-netdev.c | 3 +- > > datapath/vport-vxlan.c| 17 ++- > > These changes aren't upstream yet. Please do that bef

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-06 Thread Jesse Gross
On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: [...] > datapath/vport-netdev.c | 3 +- > datapath/vport-vxlan.c| 17 ++- These changes aren't upstream yet. Please do that before backporting them here. However, the changes to vport-vxlan.c

[ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-04 Thread Yi Yang
Current Linux kernel git tree has included VxLAN-gpe implementation author Jiri Benc committer David S. Miller commit e1e5314de08ba6003b358125eafc9ad9e75a950c (patch) tree1e18cdabf1c9d9ef17e26c6480e629465447f77f /drivers/net/vxlan.c parent a6d5bbf34efa8330af7b0b1dba0f38148516ed97 (d