Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-02-06 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Feb 6, 2013, at 2:57 , ext Jesse Gross wrote: >> >> While I would not see a problem in passing a key hash computed with an >> undisclosed algorithm up to userspace, I see your point. >> >> In my tests it seems that about 1/3 of the benefit is attainable with >> deferred >> layer pointer comp

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-02-05 Thread Jesse Gross
On Tue, Feb 5, 2013 at 8:53 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote > On Jan 31, 2013, at 3:19 , ext Jesse Gross wrote: >> On Wed, Jan 30, 2013 at 3:14 AM, Rajahalme, Jarno (NSN - FI/Espoo) >> wrote: >>> >>> Otherwise not so much use of the layer pointers, but >>> dpif_flow_stats_extract() >

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-02-05 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Jan 31, 2013, at 3:19 , ext Jesse Gross wrote: > On Wed, Jan 30, 2013 at 3:14 AM, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> Otherwise not so much use of the layer pointers, but >> dpif_flow_stats_extract() >> does packet_get_tcp_flags(), which needs the layer pointers. >> dpif_flow_s

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-30 Thread Jesse Gross
On Wed, Jan 30, 2013 at 3:14 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jan 30, 2013, at 2:59 , ext Jesse Gross wrote: > >> On Tue, Jan 29, 2013 at 7:10 AM, Rajahalme, Jarno (NSN - FI/Espoo) >> wrote: >>> >>> On Jan 24, 2013, at 19:41 , ext Jesse Gross wrote: >>> On Thu, Jan 24, 201

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-30 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Jan 30, 2013, at 2:59 , ext Jesse Gross wrote: > On Tue, Jan 29, 2013 at 7:10 AM, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> On Jan 24, 2013, at 19:41 , ext Jesse Gross wrote: >> >>> On Thu, Jan 24, 2013 at 7:34 AM, Jarno Rajahalme >>> wrote: On Jan 23, 2013, at 19:30 , ex

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-29 Thread Jesse Gross
On Tue, Jan 29, 2013 at 7:10 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Jan 24, 2013, at 19:41 , ext Jesse Gross wrote: > >> On Thu, Jan 24, 2013 at 7:34 AM, Jarno Rajahalme >> wrote: >>> >>> On Jan 23, 2013, at 19:30 , ext Jesse Gross wrote: >>> On Tue, Jan 22, 2013 at 9:48 PM, Jar

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-29 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Jan 24, 2013, at 19:41 , ext Jesse Gross wrote: > On Thu, Jan 24, 2013 at 7:34 AM, Jarno Rajahalme > wrote: >> >> On Jan 23, 2013, at 19:30 , ext Jesse Gross wrote: >> >>> On Tue, Jan 22, 2013 at 9:48 PM, Jarno Rajahalme >>> wrote: Add OVS_PACKET_ATTR_KEY_INFO to relieve userspace fro

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-24 Thread Jesse Gross
On Thu, Jan 24, 2013 at 7:34 AM, Jarno Rajahalme wrote: > > On Jan 23, 2013, at 19:30 , ext Jesse Gross wrote: > >> On Tue, Jan 22, 2013 at 9:48 PM, Jarno Rajahalme >> wrote: >>> Add OVS_PACKET_ATTR_KEY_INFO to relieve userspace from re-computing >>> data already computed within the kernel datapa

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-24 Thread Jarno Rajahalme
On Jan 23, 2013, at 19:30 , ext Jesse Gross wrote: > On Tue, Jan 22, 2013 at 9:48 PM, Jarno Rajahalme > wrote: >> Add OVS_PACKET_ATTR_KEY_INFO to relieve userspace from re-computing >> data already computed within the kernel datapath. In the typical >> case of an upcall with perfect key fitness

Re: [ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-23 Thread Jesse Gross
On Tue, Jan 22, 2013 at 9:48 PM, Jarno Rajahalme wrote: > Add OVS_PACKET_ATTR_KEY_INFO to relieve userspace from re-computing > data already computed within the kernel datapath. In the typical > case of an upcall with perfect key fitness between kernel and > userspace this eliminates flow_extract

[ovs-dev] [PATCH] RFC: Pass more packet and flow key info to userspace.

2013-01-22 Thread Jarno Rajahalme
Add OVS_PACKET_ATTR_KEY_INFO to relieve userspace from re-computing data already computed within the kernel datapath. In the typical case of an upcall with perfect key fitness between kernel and userspace this eliminates flow_extract() and flow_hash() calls in handle_miss_upcalls(). Additional bo