Re: [ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-22 Thread Ethan Jackson
Thanks, I merged it. Ethan On Wed, Jan 22, 2014 at 11:00 AM, Ben Pfaff wrote: > On Wed, Jan 22, 2014 at 10:55:59AM -0800, Ethan Jackson wrote: >> The AM_V_GEN macro fits more cleanly with the automake silent rules >> option. When enabled it will print "GEN " instead of simply >> echoing the com

Re: [ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-22 Thread Ben Pfaff
On Wed, Jan 22, 2014 at 10:55:59AM -0800, Ethan Jackson wrote: > The AM_V_GEN macro fits more cleanly with the automake silent rules > option. When enabled it will print "GEN " instead of simply > echoing the command as before. > > Signed-off-by: Ethan Jackson I understand it now. Acked-by: Be

[ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-22 Thread Ethan Jackson
The AM_V_GEN macro fits more cleanly with the automake silent rules option. When enabled it will print "GEN " instead of simply echoing the command as before. Signed-off-by: Ethan Jackson --- Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Mak

Re: [ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-22 Thread Ethan Jackson
oops that's just a mistake, I needed an else before the touch. I'll resend it. Ethan On Wed, Jan 22, 2014 at 9:29 AM, Ben Pfaff wrote: > I'm saying that "exit 1; touch $@" looks to me like a C function that > has code following a return statement. Can the "touch" ever execute? > > On Wed, Jan

Re: [ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-22 Thread Ben Pfaff
I'm saying that "exit 1; touch $@" looks to me like a C function that has code following a return statement. Can the "touch" ever execute? On Wed, Jan 22, 2014 at 09:03:30AM -0800, Ethan Jackson wrote: > Are you saying I should just do if !error then touch? Or are you > complaining about the rat

Re: [ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-22 Thread Ethan Jackson
Are you saying I should just do if !error then touch? Or are you complaining about the rather odd touch -c after? On the latter point, I struggled a bit with what to do about this. Probably the most canonically correct thing to do, is to replace "@error=false" with "$(AM_V_GEN) error=false". T

Re: [ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-21 Thread Ben Pfaff
On Tue, Jan 21, 2014 at 05:58:16PM -0800, Ethan Jackson wrote: > The AM_V_GEN macro fits more cleanly with the automake silent rules > option. When enabled it will print "GEN " instead of simply > echoing the command as before. > > Signed-off-by: Ethan Jackson I think that the first change is O

[ovs-dev] [PATCH] Makefile: Use AM_V_GEN instead of echo.

2014-01-21 Thread Ethan Jackson
The AM_V_GEN macro fits more cleanly with the automake silent rules option. When enabled it will print "GEN " instead of simply echoing the command as before. Signed-off-by: Ethan Jackson --- Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Mak