Re: [ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 04:59:40PM +0100, Ben Hutchings wrote: > I don't know anything about MPLS so this is a pretty superficial review. > > On Wed, 2013-04-03 at 14:24 +0900, Simon Horman wrote: > [...] > > --- a/include/linux/netdev_features.h > > +++ b/include/linux/netdev_features.h > > @@ -4

Re: [ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-03 Thread Ben Hutchings
I don't know anything about MPLS so this is a pretty superficial review. On Wed, 2013-04-03 at 14:24 +0900, Simon Horman wrote: [...] > --- a/include/linux/netdev_features.h > +++ b/include/linux/netdev_features.h > @@ -43,6 +43,7 @@ enum { > NETIF_F_FSO_BIT,/* ... FCoE segme

Re: [ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 06:36:29AM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Apr 3, 2013, at 8:24 , ext Simon Horman wrote: > > > In the case where a non-MPLS packet is recieved and an MPLS stack is > > added it may well be the case that the original skb is GSO but the > > NIC used

Re: [ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-02 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Apr 3, 2013, at 8:24 , ext Simon Horman wrote: > In the case where a non-MPLS packet is recieved and an MPLS stack is > added it may well be the case that the original skb is GSO but the > NIC used for transmit does not support GSO of MPLS packets. > ... > diff --git a/include/linux/netdev_fe

[ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-02 Thread Simon Horman
In the case where a non-MPLS packet is recieved and an MPLS stack is added it may well be the case that the original skb is GSO but the NIC used for transmit does not support GSO of MPLS packets. The aim of this code is to provide GSO in software for MPLS packets whose skbs are GSO. When an imple