Re: [ovs-dev] [PATCH] Improve kernel hash table

2011-09-02 Thread Jesse Gross
On Tue, Aug 23, 2011 at 3:34 PM, Pravin Shelar wrote: >     Currently OVS uses its own hashing implmentation for hash tables which > has some problems, e.g. error case on deletion code. Following patch > replaces that with hlist based hash table which is consistent with other > kernel hash tables.

Re: [ovs-dev] [PATCH] Improve kernel hash table

2011-08-24 Thread Pravin Shelar
Jesse, I forgot to commit `git rm table.c table.h` to this patch. I will do it when I push final patch. Thanks, Pravin. On Tue, Aug 23, 2011 at 3:34 PM, Pravin Shelar wrote: >     Currently OVS uses its own hashing implmentation for hash tables which > has some problems, e.g. error case on del

[ovs-dev] [PATCH] Improve kernel hash table

2011-08-23 Thread Pravin Shelar
Currently OVS uses its own hashing implmentation for hash tables which has some problems, e.g. error case on deletion code. Following patch replaces that with hlist based hash table which is consistent with other kernel hash tables. As Jesse suggested, flex-array is used for allocating hash bu

Re: [ovs-dev] [PATCH] Improve kernel hash table

2011-08-22 Thread Jesse Gross
On Mon, Aug 22, 2011 at 7:02 AM, Pravin Shelar wrote: > On Sat, Aug 20, 2011 at 4:31 AM, Jesse Gross wrote: >> On Sat, Aug 20, 2011 at 4:49 AM, Pravin Shelar wrote: >>> +int tnl_init() >>> +{ >>> +       port_table = alloc_buckets(port_table_size); >>> +       if (!port_table) >>> +            

Re: [ovs-dev] [PATCH] Improve kernel hash table

2011-08-21 Thread Pravin Shelar
On Sat, Aug 20, 2011 at 4:31 AM, Jesse Gross wrote: > On Sat, Aug 20, 2011 at 4:49 AM, Pravin Shelar wrote: >> Currently OVS used its own hashing implmentation for hash tables which >> has some problems, e.g. error case on deletion code. Following patch >> replaces that with hlist based hash tabl

Re: [ovs-dev] [PATCH] Improve kernel hash table

2011-08-20 Thread Ben Pfaff
On Fri, Aug 19, 2011 at 01:49:36PM -0700, Pravin Shelar wrote: > Currently OVS used its own hashing implmentation for hash tables which > has some problems, e.g. error case on deletion code. Following patch > replaces that with hlist based hash table which is consistent with other > kernel hash tab

Re: [ovs-dev] [PATCH] Improve kernel hash table

2011-08-20 Thread Jesse Gross
On Sat, Aug 20, 2011 at 4:49 AM, Pravin Shelar wrote: > Currently OVS used its own hashing implmentation for hash tables which > has some problems, e.g. error case on deletion code. Following patch > replaces that with hlist based hash table which is consistent with other > kernel hash tables. > >

[ovs-dev] [PATCH] Improve kernel hash table

2011-08-19 Thread Pravin Shelar
Currently OVS used its own hashing implmentation for hash tables which has some problems, e.g. error case on deletion code. Following patch replaces that with hlist based hash table which is consistent with other kernel hash tables. Signed-off-by: Pravin Shelar --- datapath/Modules.mk |2 -