Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers.

2014-01-30 Thread Linda Sun
openvswitch.org Sent: Wednesday, January 29, 2014 12:32:10 PM Subject: Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers. I think that's the only viable choice. Let's do that. On Wed, Jan 29, 2014 at 11:35:43AM -0800, Linda Sun wrote: > The other way is to

Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers.

2014-01-29 Thread Ben Pfaff
age - > From: "Linda Sun" > To: "Ben Pfaff" > Cc: dev@openvswitch.org > Sent: Wednesday, January 29, 2014 11:32:03 AM > Subject: Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non > C99 compilers. > > > Microsoft support se

Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers.

2014-01-29 Thread Linda Sun
Wednesday, January 29, 2014 11:22:18 AM Subject: Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers. I don't see how those work with any vintage of C compiler. You can't just initialize any member of a union and expect the compiler to guess which one you mean

Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers.

2014-01-29 Thread Linda Sun
Microsoft support seems to indicate that it always initializes the first member of the union. Linda - Original Message - From: "Ben Pfaff" To: "Linda Sun" Cc: dev@openvswitch.org Sent: Wednesday, January 29, 2014 11:22:18 AM Subject: Re: [ovs-dev] [PATCH] Fully i

[ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers.

2014-01-29 Thread Linda Sun
--- lib/ovsdb-types.h | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/lib/ovsdb-types.h b/lib/ovsdb-types.h index efd83a7..d3aa262 100644 --- a/lib/ovsdb-types.h +++ b/lib/ovsdb-types.h @@ -70,8 +70,8 @@ struct ovsdb_base_type { /* No constraint

Re: [ovs-dev] [PATCH] Fully initialize structures to accomodate non C99 compilers.

2014-01-29 Thread Ben Pfaff
I don't see how those work with any vintage of C compiler. You can't just initialize any member of a union and expect the compiler to guess which one you mean. On Wed, Jan 29, 2014 at 11:18:24AM -0800, Linda Sun wrote: > --- > lib/ovsdb-types.h | 20 > 1 file changed, 8 in