Re: [ovs-dev] [PATCH] Fix hindex iteration incomplete bug

2013-07-17 Thread ZhengLingyun
It seems I don't get the purpose of introducing hindex into lib. Now I get it. Thanks. At 2013-07-17 01:08:16,"Ben Pfaff" wrote: >On Tue, Jul 16, 2013 at 06:46:22PM +0800, ZhengLingyun wrote: >> As you have said in hindex.h, hindex need a high-quality hash function to >> work appropriately. So

Re: [ovs-dev] [PATCH] Fix hindex iteration incomplete bug

2013-07-16 Thread Ben Pfaff
On Tue, Jul 16, 2013 at 06:46:22PM +0800, ZhengLingyun wrote: > As you have said in hindex.h, hindex need a high-quality hash function to > work appropriately. So maybe these two kinds of hindex_head_node() are > similar in performance. No. The quality of the hash function ensures that each bucke

Re: [ovs-dev] [PATCH] Fix hindex iteration incomplete bug

2013-07-16 Thread ZhengLingyun
As you have said in hindex.h, hindex need a high-quality hash function to work appropriately. So maybe these two kinds of hindex_head_node() are similar in performance. If unfortunately hindex meets a low-quality hash function, i think it will depands on the hash function, which will more likely to

Re: [ovs-dev] [PATCH] Fix hindex iteration incomplete bug

2013-07-15 Thread Ben Pfaff
On Mon, Jul 15, 2013 at 08:21:04AM +0800, ZhengLingyun wrote: > hindex_next() shouldn't jump over different hashs in the same bucket. > tests/test-hindex did not detect it, add a multipart_hash() method to detect > it. > > > Signed-off-by: ZhengLingyun Thank you very much for finding the probl

[ovs-dev] [PATCH] Fix hindex iteration incomplete bug

2013-07-14 Thread ZhengLingyun
hindex_next() shouldn't jump over different hashs in the same bucket. tests/test-hindex did not detect it, add a multipart_hash() method to detect it. Signed-off-by: ZhengLingyun --- lib/hindex.c| 21 ++--- tests/test-hindex.c |7 +++ 2 files changed, 25 insert